Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Hayward <Alan.Hayward@arm.com>
To: Pedro Alves <palves@redhat.com>,
	Simon Marchi <simon.marchi@ericsson.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	nd <nd@arm.com>
Subject: Re: [PATCH] Replace contribution list in CONTRIBUTE file with wiki link
Date: Wed, 23 Jan 2019 17:15:00 -0000	[thread overview]
Message-ID: <46E9A635-C40D-4087-81BC-BA34DC55717F@arm.com> (raw)
In-Reply-To: <79e6aeb8-fd9d-7269-ea6c-929812fd6f71@redhat.com>

Combing both threads. New version below

> On 23 Jan 2019, at 16:03, Pedro Alves <palves@redhat.com> wrote:
> 
> On 01/23/2019 09:46 AM, Alan Hayward wrote:
> 
>> +https://sourceware.org/gdb/wiki/ContributionChecklist
> 
> I'd rather point at https://sourceware.org/gdb/contribute/
> and then have _that_ point at some page in the wiki.
> That's what I had suggested in the other thread.
> The reason is that the <https://sourceware.org/gdb/contribute/>
> URL is going to be more stable than a wiki link, which we can
> rename, split, etc. a bit more freely.  The contribution checklist page
> is quite large by now, and I've heard of people wishing for a smaller more
> concise entry point.  The checklist was meant to be that, a checklist.
> A "how to contribute" page may have some higher level info to
> get people started.
> 
> Thanks,
> Pedro Alves

Fair enough. Having the double link seemed redundant, but your
reasoning makes sense.

The sourceware contribute page itself needs an update (it currently
points to the CONTRIBUTE file!) How do we go about making that change?



> On 23 Jan 2019, at 15:21, Simon Marchi <simon.marchi@ericsson.com> wrote:
> 
> On 2019-01-23 4:46 a.m., Alan Hayward wrote:
>> 
>> You may also want to submit your change so that can be considered for
>> -conclusion in a future version of GDB (see below).  Regardless, we
>> -encourage you to distribute the change yourself.
>> +conclusion in a future version of GDB.  For a full guide on how to
>> +submit patches see:
> 
> Is it just me, or the "You may also..." sentence is very weird? conclusion
> or inclusion?  There seems to be a missing work after "so that".
> 
> Otherwise, this LGTM, thanks.
> 
> Simon

Agreed. I missed that.



Wanted to avoid rewriting as much as possible. But now I’m wondering if it
maybe needs reducing down a little more.

How about the following (can repost with proper diff, but easier to read
if I just paste it)



			Contributing to GDB

GDB is a collaborative project that relies on contributions.  You can
help in this!  You may wish to fix bugs, improve testing, port GDB to
a new platform, update documentation, add new features or optimizations,
contribute to the mailing lists or offical GDB website, etc.  We welcome
all of the above and feel free to ask on the GDB mailing lists if you are
looking for feedback or for people to review a work in progress.  For
more information see:

https://sourceware.org/gdb/


In order for any code patches to be considered for submission, please
also see the contribution guide:

https://sourceware.org/gdb/contribute/




  reply	other threads:[~2019-01-23 17:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23  9:46 Alan Hayward
2019-01-23 15:21 ` Simon Marchi
2019-01-23 16:03 ` Pedro Alves
2019-01-23 17:15   ` Alan Hayward [this message]
2019-01-24 13:00     ` Pedro Alves
2019-01-25  6:08       ` Joel Brobecker
2019-01-25 14:30       ` Alan Hayward
     [not found]         ` <e9019e9b-f57b-26e8-1d53-2736798787e0@redhat.com>
2019-01-26  6:26           ` Joel Brobecker
2019-01-28 10:02             ` Alan Hayward
2019-01-28 19:50               ` Pedro Alves
2019-01-29  5:33               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E9A635-C40D-4087-81BC-BA34DC55717F@arm.com \
    --to=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=palves@redhat.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox