Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Remove some text from --version output
Date: Wed, 16 May 2018 17:39:00 -0000	[thread overview]
Message-ID: <9ad3f1be-2532-b57f-3423-6a7bd7e8dafe@redhat.com> (raw)
In-Reply-To: <20180511194008.16382-1-tom@tromey.com>

On 05/11/2018 08:40 PM, Tom Tromey wrote:
> I happened to notice recently that "gdb --version" says:
> 
>     GNU gdb (GDB) 8.0.50.20170911-git
>     Copyright (C) 2017 Free Software Foundation, Inc.
>     License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
>     This is free software: you are free to change and redistribute it.
>     There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
>     and "show warranty" for details.
>     This GDB was configured as "x86_64-pc-linux-gnu".
>     Type "show configuration" for configuration details.
>     For bug reporting instructions, please see:
>     <http://www.gnu.org/software/gdb/bugs/>.
>     Find the GDB manual and other documentation resources online at:
>     <http://www.gnu.org/software/gdb/documentation/>.
>     For help, type "help".
>     Type "apropos word" to search for commands related to "word".
> 
> This is a bit on the wordy side, but also references interactive
> commands, which I think doesn't really make sense for --version.
Agreed.

> 
> This patch removes that text from --version, while leaving it in the
> "show version" output.  It also adds a newline between the URLs and
> the "For help, ..." text, because I thought that was easier to read.
> (Perhaps the URLs ought to be indented a bit as well, but I did not do
> that.)

I think indenting the urls would be nice.

> 
> Now the --version output looks like:
> 
>     GNU gdb (GDB) 8.1.50.20180511-git
>     Copyright (C) 2018 Free Software Foundation, Inc.
>     License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
>     This is free software: you are free to change and redistribute it.
>     There is NO WARRANTY, to the extent permitted by law.
>     This GDB was configured as "x86_64-pc-linux-gnu".
>     For bug reporting instructions, please see:
>     <http://www.gnu.org/software/gdb/bugs/>.
>     Find the GDB manual and other documentation resources online at:
>     <http://www.gnu.org/software/gdb/documentation/>.

LGTM.

I'd even support removing everything after the "NO WARRANTY" line.

The "This GDB was configured..." info can be found in
"gdb --configuration" instead.

(And I guess it if it stays, it could be argued that it'd be
reasonable to say to look at "--configuration" instead removing
the "show configuration" suggestion.  I'm not suggesting
that, though.)

Neither "gcc --version" nor "emacs --version", nor coreutils
tools' --version output, like "ls --version" talk about bug
reporting or doc resources in their output.

Thanks,
Pedro Alves


  parent reply	other threads:[~2018-05-16 17:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11 19:56 Tom Tromey
2018-05-12 15:51 ` Eli Zaretskii
2018-05-14 15:36   ` Tom Tromey
2018-05-16 17:39 ` Pedro Alves [this message]
2018-06-04 20:24   ` Tom Tromey
2018-06-05 16:38     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ad3f1be-2532-b57f-3423-6a7bd7e8dafe@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox