From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35464 invoked by alias); 16 May 2018 17:17:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35455 invoked by uid 89); 16 May 2018 17:17:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=GPL, gpl, H*M:b57f, online X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 17:17:19 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 031C0401EF08; Wed, 16 May 2018 17:17:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83B3C6F9E6; Wed, 16 May 2018 17:17:17 +0000 (UTC) Subject: Re: [RFA] Remove some text from --version output To: Tom Tromey , gdb-patches@sourceware.org References: <20180511194008.16382-1-tom@tromey.com> From: Pedro Alves Message-ID: <9ad3f1be-2532-b57f-3423-6a7bd7e8dafe@redhat.com> Date: Wed, 16 May 2018 17:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180511194008.16382-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00358.txt.bz2 On 05/11/2018 08:40 PM, Tom Tromey wrote: > I happened to notice recently that "gdb --version" says: > > GNU gdb (GDB) 8.0.50.20170911-git > Copyright (C) 2017 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "x86_64-pc-linux-gnu". > Type "show configuration" for configuration details. > For bug reporting instructions, please see: > . > Find the GDB manual and other documentation resources online at: > . > For help, type "help". > Type "apropos word" to search for commands related to "word". > > This is a bit on the wordy side, but also references interactive > commands, which I think doesn't really make sense for --version. Agreed. > > This patch removes that text from --version, while leaving it in the > "show version" output. It also adds a newline between the URLs and > the "For help, ..." text, because I thought that was easier to read. > (Perhaps the URLs ought to be indented a bit as well, but I did not do > that.) I think indenting the urls would be nice. > > Now the --version output looks like: > > GNU gdb (GDB) 8.1.50.20180511-git > Copyright (C) 2018 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > This GDB was configured as "x86_64-pc-linux-gnu". > For bug reporting instructions, please see: > . > Find the GDB manual and other documentation resources online at: > . LGTM. I'd even support removing everything after the "NO WARRANTY" line. The "This GDB was configured..." info can be found in "gdb --configuration" instead. (And I guess it if it stays, it could be argued that it'd be reasonable to say to look at "--configuration" instead removing the "show configuration" suggestion. I'm not suggesting that, though.) Neither "gcc --version" nor "emacs --version", nor coreutils tools' --version output, like "ls --version" talk about bug reporting or doc resources in their output. Thanks, Pedro Alves