Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <lancelot.six@amd.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, gdbserver, gdbsupport: use [noreturn] instead of ATTRIBUTE_NORETURN
Date: Tue, 16 Jul 2024 18:31:10 -0400	[thread overview]
Message-ID: <9a95fbad-b3b5-4fcc-933b-7cbc10dda793@polymtl.ca> (raw)
In-Reply-To: <20240716212403.3uzr723mw7rbv7lw@khazad-dum>



On 2024-07-16 17:24, Lancelot SIX wrote:
> On Tue, Jul 16, 2024 at 04:02:12PM -0400, Simon Marchi wrote:
>> C++ 11 has a built-in attribute for this, no need to use a compat macro.
>>
>> Change-Id: I90e4220d26e8f3949d91761f8a13cd9c37da3875
> 
> Hi Simon,
> 
> Thanks for doing this!
> 
> FWIW, this looks good to me.
> 
> Reviewed-by: Lancelot Six <lancelot.six@amd.com>
> 
> Best,
> Lancelot.

Thanks, pushed.

Simon

      reply	other threads:[~2024-07-16 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 20:02 [PATCH] gdb, gdbserver, gdbsupport: use [[noreturn]] " Simon Marchi
2024-07-16 21:24 ` [PATCH] gdb, gdbserver, gdbsupport: use [noreturn] " Lancelot SIX
2024-07-16 22:31   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a95fbad-b3b5-4fcc-933b-7cbc10dda793@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=lancelot.six@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox