From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lPykGsv0lmZx3ygAWB0awg (envelope-from ) for ; Tue, 16 Jul 2024 18:31:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=FrOICB4/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5A7101E0C3; Tue, 16 Jul 2024 18:31:39 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 422A91E030 for ; Tue, 16 Jul 2024 18:31:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF4E838449D0 for ; Tue, 16 Jul 2024 22:31:36 +0000 (GMT) Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 828D93858C56 for ; Tue, 16 Jul 2024 22:31:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 828D93858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 828D93858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721169079; cv=none; b=SGj1u1hifUH6iGt2wyiHxYfh7p78NPc3tFW7t3pCWVbI+RVKIPbpmmxGXsHWl/Esjsdmk4dlZ4uquSzXCFIshqNInPJaN892ENQ5U6i5oP4yn3XMRJVfHQtvEECu1Hw/jhSOkwTHfqYSDtAo41Sr8tMEGBukvoSMlc3ftI4TJtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721169079; c=relaxed/simple; bh=FyzsDBgvDY64QTSiqCSACHXR1ws5+Ai5/8MsqdfqEf4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=QjSdwcmLqLDyklgF539Sdp1WYG4mviIM7574DM9Vpdb4TPQoeJnEGD5kDmDIhE4CNKg3ew+QpYyS1mdUIMX7+UjGQOcPV0OD/7JfvW4V7h/DOFiZcopiUx702hgoqS2AvnvEMIhSV8b1czExfO9jaibQNLKRAiCPY9q4TzmV9x4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 46GMVBwQ103625 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jul 2024 18:31:16 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 46GMVBwQ103625 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1721169077; bh=fT0UVbnbt5/uv/HdM+GJ4ch3ZIAzGlUfCCLXVWxfhME=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=FrOICB4/UJwOwVeGazY9s3aOPb3yMZnDHk7NZgBpMLlK/yf109y3FctCYNvGQnG8G WFH5ZX8ZZZcOkWQvdVUA7ZhiJSMfuRw07yVAHiGZJift/8HPubCQvtPCvggzEZVYeb 4fT4xvuV/BgxYUOFMaH38xopEne1Syw2axk+EA0M= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7E8761E030; Tue, 16 Jul 2024 18:31:11 -0400 (EDT) Message-ID: <9a95fbad-b3b5-4fcc-933b-7cbc10dda793@polymtl.ca> Date: Tue, 16 Jul 2024 18:31:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, gdbserver, gdbsupport: use [noreturn] instead of ATTRIBUTE_NORETURN To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20240716200218.2249262-1-simon.marchi@polymtl.ca> <20240716212403.3uzr723mw7rbv7lw@khazad-dum> Content-Language: en-US From: Simon Marchi In-Reply-To: <20240716212403.3uzr723mw7rbv7lw@khazad-dum> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 16 Jul 2024 22:31:11 +0000 X-Spam-Status: No, score=-3030.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-07-16 17:24, Lancelot SIX wrote: > On Tue, Jul 16, 2024 at 04:02:12PM -0400, Simon Marchi wrote: >> C++ 11 has a built-in attribute for this, no need to use a compat macro. >> >> Change-Id: I90e4220d26e8f3949d91761f8a13cd9c37da3875 > > Hi Simon, > > Thanks for doing this! > > FWIW, this looks good to me. > > Reviewed-by: Lancelot Six > > Best, > Lancelot. Thanks, pushed. Simon