From: Simon Marchi <simark@simark.ca>
To: Alan Hayward <Alan.Hayward@arm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH v2 3/8] AArch64: Read pauth registers
Date: Thu, 21 Mar 2019 20:56:00 -0000 [thread overview]
Message-ID: <98a6f4cc-34c4-7728-4ed0-8406a9c5b6cb@simark.ca> (raw)
In-Reply-To: <20190306133325.2531-4-alan.hayward@arm.com>
On 2019-03-06 8:33 a.m., Alan Hayward wrote:
> @@ -445,6 +473,11 @@ aarch64_linux_nat_target::fetch_registers (struct regcache *regcache,
> fetch_sveregs_from_thread (regcache);
> else
> fetch_fpregs_from_thread (regcache);
> +
> + if (tdep->has_pauth ())
> + if (regno == AARCH64_PAUTH_DMASK_REGNUM (tdep->pauth_reg_base)
> + || regno == AARCH64_PAUTH_CMASK_REGNUM (tdep->pauth_reg_base))
> + fetch_pauth_masks_from_thread (regcache);
> }
Just this nit:
The "outer" if should have curly braces.
Ref:
https://www.gnu.org/prep/standards/html_node/Syntactic-Conventions.html#Syntactic-Conventions
Simon
next prev parent reply other threads:[~2019-03-21 20:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 13:33 [PATCH v2 0/8] Support for AArch64 Pointer Authentication Alan Hayward
2019-03-06 13:33 ` [PATCH v2 4/8] AArch64: gdbserver: read pauth registers Alan Hayward
2019-03-21 21:03 ` Simon Marchi
2019-03-06 13:33 ` [PATCH v2 3/8] AArch64: Read " Alan Hayward
2019-03-21 20:56 ` Simon Marchi [this message]
2019-03-06 13:33 ` [PATCH v2 1/8] AArch64: Add pointer authentication feature Alan Hayward
2019-03-06 15:36 ` Eli Zaretskii
2019-03-06 13:33 ` [PATCH v2 6/8] AArch64: DWARF unwinder support for signed return addresses Alan Hayward
2019-03-06 13:33 ` [PATCH v2 8/8] AArch64: Read pauth section from core files Alan Hayward
2019-03-06 13:33 ` [PATCH v2 2/8] AArch64: Use HWCAP to detect pauth feature Alan Hayward
2019-03-21 20:51 ` Simon Marchi
2019-03-22 12:06 ` Alan Hayward
2019-03-06 13:33 ` [PATCH v2 7/8] AArch64: Prologue scan unwinder support for signed return addresses Alan Hayward
2019-03-06 13:33 ` [PATCH v2 5/8] AArch64: Add pauth DWARF registers Alan Hayward
2019-03-14 12:34 ` [PATCH v2 0/8] Support for AArch64 Pointer Authentication Alan Hayward
2019-03-21 21:29 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a6f4cc-34c4-7728-4ed0-8406a9c5b6cb@simark.ca \
--to=simark@simark.ca \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox