From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154784-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5328 invoked by alias); 21 Mar 2019 20:56:27 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5312 invoked by uid 89); 21 Mar 2019 20:56:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Mar 2019 20:56:25 +0000
Received: from [172.16.0.89] (192-222-157-41.qc.cable.ebox.net [192.222.157.41])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 71B991E4F4;	Thu, 21 Mar 2019 16:56:23 -0400 (EDT)
Subject: Re: [PATCH v2 3/8] AArch64: Read pauth registers
To: Alan Hayward <Alan.Hayward@arm.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
References: <20190306133325.2531-1-alan.hayward@arm.com> <20190306133325.2531-4-alan.hayward@arm.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <98a6f4cc-34c4-7728-4ed0-8406a9c5b6cb@simark.ca>
Date: Thu, 21 Mar 2019 20:56:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190306133325.2531-4-alan.hayward@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-03/txt/msg00472.txt.bz2

On 2019-03-06 8:33 a.m., Alan Hayward wrote:
> @@ -445,6 +473,11 @@ aarch64_linux_nat_target::fetch_registers (struct regcache *regcache,
>       fetch_sveregs_from_thread (regcache);
>     else
>       fetch_fpregs_from_thread (regcache);
> +
> +  if (tdep->has_pauth ())
> +    if (regno == AARCH64_PAUTH_DMASK_REGNUM (tdep->pauth_reg_base)
> +	|| regno == AARCH64_PAUTH_CMASK_REGNUM (tdep->pauth_reg_base))
> +      fetch_pauth_masks_from_thread (regcache);
>   }

Just this nit:

The "outer" if should have curly braces.

Ref: 
https://www.gnu.org/prep/standards/html_node/Syntactic-Conventions.html#Syntactic-Conventions

Simon