From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Change install_breakpoint to take a std::unique_ptr
Date: Tue, 22 Aug 2017 08:56:00 -0000 [thread overview]
Message-ID: <97e95bfe-8777-14f5-52da-9dca75af4c3c@redhat.com> (raw)
In-Reply-To: <877exwjlxm.fsf@tromey.com>
On 08/22/2017 04:55 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> [...]
> Pedro> or change add_to_breakpoint_chain to take an rvalue-ref unique_ptr
> Pedro> too, and return the raw breakpoint, and then write here:
> Pedro> breakpoint *b = add_to_breakpoint_chain (std::move (arg));
>
> Sounds good. I actually considered this but thought maybe it was a step
> too far... hah.
>
> How's this?
Perfect.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-08-22 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 13:54 [RFA 0/2] small clean ups in breakpoint allocation Tom Tromey
2017-08-20 14:06 ` [RFA 2/2] Change install_breakpoint to take a std::unique_ptr Tom Tromey
2017-08-21 10:12 ` Pedro Alves
2017-08-22 3:55 ` Tom Tromey
2017-08-22 8:56 ` Pedro Alves [this message]
2017-08-20 14:06 ` [RFA 1/2] Fix erroneous cleanup use in add_solib_catchpoint Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e95bfe-8777-14f5-52da-9dca75af4c3c@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox