From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89233 invoked by alias); 22 Aug 2017 08:56:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76391 invoked by uid 89); 22 Aug 2017 08:49:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HX-Greylist:Tue, Hows, How's, perfect X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Aug 2017 08:49:45 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 904EAC058EBE; Tue, 22 Aug 2017 08:49:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 904EAC058EBE Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B7C668187B; Tue, 22 Aug 2017 08:49:41 +0000 (UTC) Subject: Re: [RFA 2/2] Change install_breakpoint to take a std::unique_ptr To: Tom Tromey References: <20170820135402.1213-1-tom@tromey.com> <20170820135402.1213-3-tom@tromey.com> <877exwjlxm.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <97e95bfe-8777-14f5-52da-9dca75af4c3c@redhat.com> Date: Tue, 22 Aug 2017 08:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <877exwjlxm.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00414.txt.bz2 On 08/22/2017 04:55 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > [...] > Pedro> or change add_to_breakpoint_chain to take an rvalue-ref unique_ptr > Pedro> too, and return the raw breakpoint, and then write here: > Pedro> breakpoint *b = add_to_breakpoint_chain (std::move (arg)); > > Sounds good. I actually considered this but thought maybe it was a step > too far... hah. > > How's this? Perfect. Thanks, Pedro Alves