From: Sandra Loosemore <sandra@codesourcery.com>
To: Pedro Alves <palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
<qiyao@sourceware.org>, Kevin Buettner <kevinb@redhat.com>
Subject: Re: [patch, nios2] fix stepping past unwritable kernel helper
Date: Thu, 28 Mar 2019 16:34:00 -0000 [thread overview]
Message-ID: <97a603c9-ebee-4343-09c3-f7f3d8e63a62@codesourcery.com> (raw)
In-Reply-To: <25d33f77-a884-c214-5dbb-0d45863e5a75@redhat.com>
On 3/28/19 5:39 AM, Pedro Alves wrote:
> On 03/28/2019 04:47 AM, Sandra Loosemore wrote:
>> +static int
>> +nios2_linux_is_kernel_helper (CORE_ADDR pc)
>> +{
>> + return pc == 0x1004;
>> +}
>> +
>
>> + /* Returns true if PC points to a kernel helper function. */
>> + int (*is_kernel_helper) (CORE_ADDR pc);
>
> Nit: please make these return bool instead of int.
Thanks for the speedy review. I've pushed the patch with that tweak as
commit f489207efde922e436b1b420d4de071927e3b9d5.
-Sandra
prev parent reply other threads:[~2019-03-28 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 4:47 Sandra Loosemore
2019-03-28 6:08 ` Kevin Buettner
[not found] ` <25d33f77-a884-c214-5dbb-0d45863e5a75@redhat.com>
2019-03-28 16:34 ` Sandra Loosemore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a603c9-ebee-4343-09c3-f7f3d8e63a62@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=palves@redhat.com \
--cc=qiyao@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox