From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155031-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 88457 invoked by alias); 28 Mar 2019 16:34:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 88439 invoked by uid 89); 28 Mar 2019 16:34:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:556, H*r:0700
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Mar 2019 16:34:16 +0000
Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203])	by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256)	id 1h9Xyo-0006U6-S8 from Sandra_Loosemore@mentor.com ; Thu, 28 Mar 2019 09:34:14 -0700
Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 28 Mar 2019 09:34:12 -0700
Subject: Re: [patch, nios2] fix stepping past unwritable kernel helper
To: Pedro Alves <palves@redhat.com>, "gdb-patches@sourceware.org"	<gdb-patches@sourceware.org>, <qiyao@sourceware.org>, Kevin Buettner	<kevinb@redhat.com>
References: <80464f56-fccb-0bb4-dcdd-6a547e5418b0@codesourcery.com> <25d33f77-a884-c214-5dbb-0d45863e5a75@redhat.com>
From: Sandra Loosemore <sandra@codesourcery.com>
Message-ID: <97a603c9-ebee-4343-09c3-f7f3d8e63a62@codesourcery.com>
Date: Thu, 28 Mar 2019 16:34:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <25d33f77-a884-c214-5dbb-0d45863e5a75@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-03/txt/msg00719.txt.bz2

On 3/28/19 5:39 AM, Pedro Alves wrote:
> On 03/28/2019 04:47 AM, Sandra Loosemore wrote:
>> +static int
>> +nios2_linux_is_kernel_helper (CORE_ADDR pc)
>> +{
>> +  return pc == 0x1004;
>> +}
>> +
> 
>> +  /* Returns true if PC points to a kernel helper function.  */
>> +  int (*is_kernel_helper) (CORE_ADDR pc);
> 
> Nit: please make these return bool instead of int.

Thanks for the speedy review.  I've pushed the patch with that tweak as
commit f489207efde922e436b1b420d4de071927e3b9d5.

-Sandra