From: "Eli Zaretskii" <eliz@gnu.org>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com, uweigand@de.ibm.com
Subject: Re: [RFA]: Fix for watchpoint regressions
Date: Tue, 22 Jun 2004 04:24:00 -0000 [thread overview]
Message-ID: <9743-Tue22Jun2004072010+0300-eliz@gnu.org> (raw)
In-Reply-To: <40D73DC0.5090601@redhat.com> (message from Jeff Johnston on Mon, 21 Jun 2004 15:57:52 -0400)
> Date: Mon, 21 Jun 2004 15:57:52 -0400
> From: Jeff Johnston <jjohnstn@redhat.com>
> >>
> >>2004-06-18 Jeff Johnston <jjohnstn@redhat.com>
> >>
> >> * infrun.c (handle_inferior_event): Initialize stopped_by_watchpoint
> >> to -1.
> >> * breakpoint.c (bpstat_stop_status): Move check for ignoring
> >> untriggered watchpoints to a separate if clause. Update function
> >> comment regarding STOPPED_BY_WATCHPOINT argument.
> >
> >
> > Won't this break the cases that caused the addition of testing that
> > stopped_by_watchpoint is non-zero in bpstat_stop_status?
> >
>
> I took care to try to ensure that the problem the original patch was fixing was
> still being addressed.
Thanks for taking time to explain the situation and the fix.
Your patch is approved.
next prev parent reply other threads:[~2004-06-22 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-21 15:40 Jeff Johnston
2004-06-21 19:07 ` Eli Zaretskii
2004-06-21 19:57 ` Jeff Johnston
2004-06-22 4:24 ` Eli Zaretskii [this message]
2004-06-22 19:47 ` Jeff Johnston
2004-06-21 20:18 Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9743-Tue22Jun2004072010+0300-eliz@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox