From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10894 invoked by alias); 22 Jun 2004 04:24:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10883 invoked from network); 22 Jun 2004 04:24:09 -0000 Received: from unknown (HELO aragorn.inter.net.il) (192.114.186.23) by sourceware.org with SMTP; 22 Jun 2004 04:24:09 -0000 Received: from zaretski (pns03-204-123.inter.net.il [80.230.204.123]) by aragorn.inter.net.il (MOS 3.4.6-GR) with ESMTP id DHU29567; Tue, 22 Jun 2004 07:23:59 +0300 (IDT) Date: Tue, 22 Jun 2004 04:24:00 -0000 From: "Eli Zaretskii" To: Jeff Johnston Message-Id: <9743-Tue22Jun2004072010+0300-eliz@gnu.org> CC: gdb-patches@sources.redhat.com, uweigand@de.ibm.com In-reply-to: <40D73DC0.5090601@redhat.com> (message from Jeff Johnston on Mon, 21 Jun 2004 15:57:52 -0400) Subject: Re: [RFA]: Fix for watchpoint regressions Reply-to: Eli Zaretskii References: <40D7016F.1070406@redhat.com> <2719-Mon21Jun2004220328+0300-eliz@gnu.org> <40D73DC0.5090601@redhat.com> X-SW-Source: 2004-06/txt/msg00492.txt.bz2 > Date: Mon, 21 Jun 2004 15:57:52 -0400 > From: Jeff Johnston > >> > >>2004-06-18 Jeff Johnston > >> > >> * infrun.c (handle_inferior_event): Initialize stopped_by_watchpoint > >> to -1. > >> * breakpoint.c (bpstat_stop_status): Move check for ignoring > >> untriggered watchpoints to a separate if clause. Update function > >> comment regarding STOPPED_BY_WATCHPOINT argument. > > > > > > Won't this break the cases that caused the addition of testing that > > stopped_by_watchpoint is non-zero in bpstat_stop_status? > > > > I took care to try to ensure that the problem the original patch was fixing was > still being addressed. Thanks for taking time to explain the situation and the fix. Your patch is approved.