Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Shahab Vahedi <shahab.vahedi@gmail.com>, gdb-patches@sourceware.org
Cc: Shahab Vahedi <shahab@synopsys.com>,
	Andrew Burgess <andrew.burgess@embecosm.com>,
	Claudiu Zissulescu <claziss@synopsys.com>,
	Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH v3] GDB: Fix the overflow in addr/line_is_displayed()
Date: Mon, 06 Jan 2020 19:55:00 -0000	[thread overview]
Message-ID: <96a6f3a4-ba02-f973-538a-64eb2b6007b3@redhat.com> (raw)
In-Reply-To: <20200106142732.32733-1-shahab.vahedi@gmail.com>

Hi,

I merged this patch without waiting for copyright clearing, since the
amount of new copyrightable code is a few lines only IMO (the threshold
check), and also the current form of the patch was largely suggested
by me in a previous email.

For further fixes, I think it's better to wait until copyright
issues are cleared though.

> This commit avoids the segmentation faults with an early check:
> 
>   if (contet.size () < SCROLL_THRESHOLD)
>     return false;

I fixed the "contet" typo before merging.

Thanks,
Pedro Alves


      reply	other threads:[~2020-01-06 19:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200106102649.15710-1-shahab.vahedi@gmail.com>
2020-01-06 12:18 ` [PATCH v2] GDB: Fix the overflow in addr_is_displayed() Pedro Alves
2020-01-06 12:43   ` Shahab Vahedi
2020-01-06 13:03     ` Pedro Alves
2020-01-06 14:27       ` [PATCH v3] GDB: Fix the overflow in addr/line_is_displayed() Shahab Vahedi
2020-01-06 19:55         ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96a6f3a4-ba02-f973-538a-64eb2b6007b3@redhat.com \
    --to=palves@redhat.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=claziss@synopsys.com \
    --cc=fbedard@synopsys.com \
    --cc=gdb-patches@sourceware.org \
    --cc=shahab.vahedi@gmail.com \
    --cc=shahab@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox