From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109579 invoked by alias); 6 Jan 2020 19:55:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109567 invoked by uid 89); 6 Jan 2020 19:55:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:590 X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2020 19:55:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578340549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R9aIalf6iWj1XV7w1xvADi3dfQ3Dw02BkzEV+TPZ8Xk=; b=fiNa8OmLQ4bRM7MfytcluFCUbNxkMx/j+w2mZ49HRNot0s2+xSihkz+fNbYu6ArGVwWSXE mHkxAvAOQ5yg+9sxETxhfBAn55S27jgYMgW6ynYg/InFlijHmZC7sOTFkdLebbnaR0HhiL xIqjcK5WzLx6/BpEKMq7IuYD7jSRJbY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-a6oeStOHNA6o3VPWdkZtLw-1; Mon, 06 Jan 2020 14:55:46 -0500 Received: by mail-wm1-f70.google.com with SMTP id t16so3229569wmt.4 for ; Mon, 06 Jan 2020 11:55:46 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id x14sm23909010wmj.42.2020.01.06.11.55.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2020 11:55:45 -0800 (PST) Subject: Re: [PATCH v3] GDB: Fix the overflow in addr/line_is_displayed() To: Shahab Vahedi , gdb-patches@sourceware.org References: <45a718f7-e905-e7b1-1596-6ef6c4204176@redhat.com> <20200106142732.32733-1-shahab.vahedi@gmail.com> Cc: Shahab Vahedi , Andrew Burgess , Claudiu Zissulescu , Francois Bedard From: Pedro Alves Message-ID: <96a6f3a4-ba02-f973-538a-64eb2b6007b3@redhat.com> Date: Mon, 06 Jan 2020 19:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200106142732.32733-1-shahab.vahedi@gmail.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00131.txt.bz2 Hi, I merged this patch without waiting for copyright clearing, since the amount of new copyrightable code is a few lines only IMO (the threshold check), and also the current form of the patch was largely suggested by me in a previous email. For further fixes, I think it's better to wait until copyright issues are cleared though. > This commit avoids the segmentation faults with an early check: > > if (contet.size () < SCROLL_THRESHOLD) > return false; I fixed the "contet" typo before merging. Thanks, Pedro Alves