From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lancelot.six@amd.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/10] gdb/solib-rocm: add cached_target_fd to manage cached fd lifetime
Date: Tue, 7 Jul 2026 16:48:25 -0400 [thread overview]
Message-ID: <963dd291-32f9-4302-8261-740732ed54ce@simark.ca> (raw)
In-Reply-To: <eibno2qsiqzomwnrru4nvwe4hnwfjxak3vzehsroumn3fychqo@wcov7xt42pes>
On 2026-07-06 13:08, Lancelot SIX wrote:
> On Mon, Jun 08, 2026 at 04:00:27PM -0400, Simon Marchi wrote:
>> Make the management of the cached fds automatic.
>>
>> Change rocm_solib_fd_cache::open to return a cached_target_fd, an RAII
>> type that calls rocm_solib_fd_cache::close on destruction.
>> cached_target_fd holds the actual fd and a reference to the cache it
>> comes from.
>>
>> Change rocm_code_object_stream_file to hold a cached_target_fd and
>> remove the explicit destructor.
>>
>> This is not essential, I just thought it would be nice.
>
> Hi Simon,
>
> This overall looks good. Just have one minor nits below. Other than that,
>
> Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)
Thanks, fixed both.
Simon
next prev parent reply other threads:[~2026-07-07 20:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 20:00 [PATCH RESEND v2 00/10] Multiple solib_ops in a program_space Simon Marchi
2026-06-08 20:00 ` [PATCH RESEND v2 01/10] gdb/solib-rocm: assert that host ops isn't rocm_solib_ops Simon Marchi
2026-07-06 17:08 ` [PATCH v2 1/10] " Lancelot SIX
2026-06-08 20:00 ` [PATCH RESEND v2 02/10] gdb/solib-rocm: pass reference to cache to rocm_code_object_stream_file Simon Marchi
2026-06-08 20:00 ` [PATCH RESEND v2 03/10] gdb/solib-rocm: add cached_target_fd to manage cached fd lifetime Simon Marchi
2026-07-06 17:08 ` [PATCH v2 3/10] " Lancelot SIX
2026-07-07 20:48 ` Simon Marchi [this message]
2026-06-08 20:00 ` [PATCH RESEND v2 04/10] gdb: de-constify some methods of solib_ops Simon Marchi
2026-07-06 17:09 ` [PATCH v2 4/10] " Lancelot SIX
2026-06-08 20:00 ` [PATCH RESEND v2 05/10] gdb/solib-rocm: move per-inferior data to rocm_solib_ops Simon Marchi
2026-07-06 17:09 ` [PATCH v2 5/10] " Lancelot SIX
2026-07-08 16:08 ` Simon Marchi
2026-06-08 20:00 ` [PATCH RESEND v2 06/10] gdb/solib-rocm: save inferior in rocm_solib_ops Simon Marchi
2026-07-06 17:10 ` [PATCH v2 6/10] " Lancelot SIX
2026-06-08 20:00 ` [PATCH RESEND v2 07/10] gdb/solib: add remove_solib function Simon Marchi
2026-06-08 20:00 ` [PATCH RESEND v2 08/10] gdb: add objfile -> solib backlink Simon Marchi
2026-06-08 20:00 ` [PATCH RESEND v2 09/10] gdb: change default objfile iteration order to start with current objfile Simon Marchi
2026-06-08 20:00 ` [PATCH RESEND v2 10/10] gdb: multiple solib_ops per program space Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963dd291-32f9-4302-8261-740732ed54ce@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox