From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4AcIMTdmTWr7bysAWB0awg (envelope-from ) for ; Tue, 07 Jul 2026 16:48:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1783457335; bh=FG1wDInIXUzcAiSRYD6YuXR/hSq0BtMwwg9BGlDw4EY=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CTDS3eNh1gz+K77wltp8N0Q9rJ96qV6MMgo5qXk3d0plknIIuJ+YEn40LG5SY50Hh QlP5wNdTGK2+wVtJFX7/0C4qoOqzVDnGUvnn36YhjrmVR0YFNGnFJuHmn8VmmuoE3v 4nq1rbXWRkwoe0H0kV1Io4lY8zbu4JMGUKy2HKgQ= Received: by simark.ca (Postfix, from userid 112) id B76E21E024; Tue, 07 Jul 2026 16:48:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=omrhR5OV; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A0AAD1E024 for ; Tue, 07 Jul 2026 16:48:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0CDA4BA2E2D for ; Tue, 7 Jul 2026 20:48:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0CDA4BA2E2D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=omrhR5OV Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EEF524BA2E1B for ; Tue, 7 Jul 2026 20:48:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEF524BA2E1B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EEF524BA2E1B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783457309; cv=none; b=h1r5h9mzk7Ud0wksxvBAKIpIObYxTwozIKI/dzrNDS6r6oG9EAFYnopXJOZbNz/bRwuk7HajsgrOMuyb4ecvhc6bUc6jQDxH+Gfcet5DVU+Tvn3OkMfX+9ZJxEgbR4aZ15jR+S30Q94e8xEobH1Z3GxcUn7M7z1OmRbeRl16aMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783457309; c=relaxed/simple; bh=FG1wDInIXUzcAiSRYD6YuXR/hSq0BtMwwg9BGlDw4EY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pPAzALLhuCg4+mudkxibu05FDZCtoGkeKfzzXUeMf39kNponWL0Ci6aWnzYyB/iT5x8rzPonvA/WLNoVNJyCUNpP5TpPrV8sRWqgXJg+nJIHMmzU2fROQUBixOfEkgf2YIsDhzltgrKUCSShVBR3eatLSfpZlSN0RHx28Fh3C4c= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=omrhR5OV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEF524BA2E1B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1783457305; bh=FG1wDInIXUzcAiSRYD6YuXR/hSq0BtMwwg9BGlDw4EY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=omrhR5OVsvFducjTv1A2JrOoqjREdX5//3s4sQ3dNKBFi2yKtJ5Q2Xr2pa2MNoego U7+7SKpFpYmlqcQ+Q6qR9acYe+v8jObFgl9gauP5wNOcGZ4lCu/+/YYlX49fOx5xNk 6uJWn0KWQhKiwEWQt6n0R4TPcHV2NQrFcgA6qapE= Received: by simark.ca (Postfix) id 858DD1E024; Tue, 07 Jul 2026 16:48:25 -0400 (EDT) Message-ID: <963dd291-32f9-4302-8261-740732ed54ce@simark.ca> Date: Tue, 7 Jul 2026 16:48:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/10] gdb/solib-rocm: add cached_target_fd to manage cached fd lifetime To: Lancelot SIX , Simon Marchi , gdb-patches@sourceware.org References: <20260608200100.666134-4-simon.marchi@efficios.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-07-06 13:08, Lancelot SIX wrote: > On Mon, Jun 08, 2026 at 04:00:27PM -0400, Simon Marchi wrote: >> Make the management of the cached fds automatic. >> >> Change rocm_solib_fd_cache::open to return a cached_target_fd, an RAII >> type that calls rocm_solib_fd_cache::close on destruction. >> cached_target_fd holds the actual fd and a reference to the cache it >> comes from. >> >> Change rocm_code_object_stream_file to hold a cached_target_fd and >> remove the explicit destructor. >> >> This is not essential, I just thought it would be nice. > > Hi Simon, > > This overall looks good. Just have one minor nits below. Other than that, > > Approved-by: Lancelot Six (amdgpu) Thanks, fixed both. Simon