From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Luis Machado <luis.machado@arm.com>,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] Disable year 2038 support on 32-bit hosts by default
Date: Mon, 1 Aug 2022 10:08:34 -0400 [thread overview]
Message-ID: <959a19b9-b2c3-6638-e0b9-b66ca8328574@simark.ca> (raw)
In-Reply-To: <20220801075149.1152064-1-luis.machado@arm.com>
On 2022-08-01 03:51, Luis Machado via Gdb-patches wrote:
> With a recent import of gnulib, code has been pulled that tests and enables
> 64-bit time_t by default on 32-bit hosts that support it.
>
> Although gdb can use the gnulib support, bfd doesn't use gnulib and currently
> doesn't do these checks.
>
> As a consequence, if we have a 32-bit host that supports 64-bit time_t, we'll
> have a mismatch between gdb's notion of time_t and bfd's notion of time_t.
>
> This will lead to mismatches in the struct stat size, leading to memory
> corruption and crashes.
>
> This patch disables the year 2038 check for now, which makes things work
> reliably again.
>
> I'd consider this a temporary fix until we have proper bfd checks for the year
> 2038, if it makes sense. 64-bit hosts seems to be more common these days, so
> I'm not sure how important it is to have this support enabled and how soon
> we want to enable it.
I don't understand: why offer a --enable-year2038 switch if using it
would produce a broken build?
Simon
next prev parent reply other threads:[~2022-08-01 14:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 7:51 Luis Machado via Gdb-patches
2022-08-01 14:08 ` Simon Marchi via Gdb-patches [this message]
2022-08-01 14:17 ` Luis Machado via Gdb-patches
2022-08-01 15:37 ` Simon Marchi via Gdb-patches
2022-08-01 15:58 ` Eli Zaretskii via Gdb-patches
2022-08-02 6:42 ` Luis Machado via Gdb-patches
2022-08-08 11:34 ` Luis Machado via Gdb-patches
2022-08-08 11:58 ` Eli Zaretskii via Gdb-patches
2022-08-08 12:04 ` Luis Machado via Gdb-patches
2022-08-08 12:38 ` Eli Zaretskii via Gdb-patches
2022-08-08 17:55 ` Paul Eggert
2022-08-08 18:00 ` Luis Machado via Gdb-patches
2022-08-08 18:01 ` Luis Machado via Gdb-patches
2022-08-09 15:49 ` Paul Eggert
2022-08-09 15:59 ` Luis Machado via Gdb-patches
2022-08-09 16:13 ` Paul Eggert
2022-08-10 9:41 ` Nick Clifton via Gdb-patches
2022-08-10 10:14 ` Luis Machado via Gdb-patches
2022-08-09 16:29 ` Eli Zaretskii via Gdb-patches
2022-08-09 17:02 ` Paul Eggert
2022-08-10 8:38 ` Alan Modra via Gdb-patches
2022-08-08 14:51 ` Nick Clifton via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=959a19b9-b2c3-6638-e0b9-b66ca8328574@simark.ca \
--to=gdb-patches@sourceware.org \
--cc=binutils@sourceware.org \
--cc=luis.machado@arm.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox