Re: [PATCH] Disable year 2038 support on 32-bit hosts by default

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 1542 bytes --]

On 8/8/22 11:01, Luis Machado wrote:
> BFD is left in the dark about the 64-bit time_t support for 32-bit hosts.

OK, but how about if we fix that by syncing non-Gnulib-using code with 
Gnulib-using code? This should be relatively easy. Something like the 
first attached patch, say. If there's still interest in 32-bit binutils 
this would be a better approach. (If there's not, then we don't have to 
install any patch. :-)

PS. While looking into this I noticed a grep portability bug in a couple 
of 'configure.ac's, fixed in the 2nd attached patch.

PPS. I couldn't get a 32-bit version of binutils-gdb to build on Fedora 
x86-64, even without either of the attached patches. See the 3rd 
attached file, which is a compressed log of my attempt to build. Here's 
the first part of the failing output:

   /bin/sh ../libtool  --tag=CXX   --mode=link gcc -m32 -Wall -pthread 
-Wno-switch -g -O2       -o gp-archive gp-archive.o ArchiveExp.o 
libgprofng.la  -L../../zlib -lz
   libtool: link: gcc -m32 -Wall -pthread -Wno-switch -g -O2 -o 
gp-archive gp-archive.o ArchiveExp.o  ./.libs/libgprofng.a 
-L/home/eggert/src/gnu/build/zlib -L/home/eggert/src/gnu/build/libiberty 
/home/eggert/src/gnu/build/opcodes/.libs/libopcodes.a 
/home/eggert/src/gnu/build/bfd/.libs/libbfd.a -liberty -lpthread -ldl 
-lz -pthread
   /usr/bin/ld: gp-archive.o: in function `er_archive::check_args(int, 
char**)':
 
/home/eggert/src/gnu/build/gprofng/src/../../../binutils-gdb/gprofng/src/gp-archive.cc:573: 
undefined reference to `operator new(unsigned int)'

[-- Attachment #2: 0001-Use-the-same-_TIME_BITS-everywhere.patch --]
[-- Type: text/x-patch, Size: 1394 bytes --]

From 4809a5538015f82fdbe5aec5d6fdaab5fefa07ba Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 9 Aug 2022 07:44:49 -0700
Subject: [PATCH 1/2] Use the same _TIME_BITS everywhere

* largefile.m4: Include Gnulib's largefile.m4 and year2038.m4.
---
 config/ChangeLog    | 5 +++++
 config/largefile.m4 | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/config/ChangeLog b/config/ChangeLog
index 3385292b3dc..f19422f27e7 100644
--- a/config/ChangeLog
+++ b/config/ChangeLog
@@ -1,3 +1,8 @@
+2022-08-09  Paul Eggert  <eggert@cs.ucla.edu>
+
+	Use the same _TIME_BITS everywhere
+	* largefile.m4: Include Gnulib's largefile.m4 and year2038.m4.
+
 2022-07-08  Nick Clifton  <nickc@redhat.com>
 
 	* 2.39 branch created.
diff --git a/config/largefile.m4 b/config/largefile.m4
index 937596334cd..1521e7c59bd 100644
--- a/config/largefile.m4
+++ b/config/largefile.m4
@@ -3,6 +3,12 @@
 # bfd's configure script so that all the directories agree on the size
 # of structures used to describe files.
 
+# Use the same version of AC_SYS_LARGEFILE that Gnulib uses,
+# as it may set _FILE_OFFSET_BITS and/or _TIME_BITS and this
+# needs to be consistent across binutils.
+m4_include([../gnulib/import/m4/largefile.m4])
+m4_include([../gnulib/import/m4/year2038.m4])
+
 AC_DEFUN([ACX_LARGEFILE],[dnl
 
 # The tests for host and target for $enable_largefile require
-- 
2.37.1


[-- Attachment #3: 0002-Avoid-undefined-in-regexp.patch --]
[-- Type: text/x-patch, Size: 2238 bytes --]

From 4695c75036bb6c632baa646e4dd2d084d81b23f7 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 9 Aug 2022 07:48:25 -0700
Subject: [PATCH 2/2] Avoid undefined \- in regexp

* configure.ac, libiberty/configure.ac:
(AR_PLUGIN_OPTION, RANLIB_PLUGIN_OPTION):
Don't use 'grep "\-..."' as POSIX says the interpretation
of \- is undefined in a regular expression.
---
 ChangeLog              | 8 ++++++++
 configure.ac           | 4 ++--
 libiberty/configure.ac | 4 ++--
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8a84e119e53..44b4233bde6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2022-08-09  Paul Eggert  <eggert@cs.ucla.edu>
+
+	Avoid undefined \- in regexp
+	* configure.ac, libiberty/configure.ac:
+	(AR_PLUGIN_OPTION, RANLIB_PLUGIN_OPTION):
+	Don't use 'grep "\-..."' as POSIX says the interpretation
+	of \- is undefined in a regular expression.
+
 2022-07-08  Nick Clifton  <nickc@redhat.com>
 
 	* 2.39 branch created.
diff --git a/configure.ac b/configure.ac
index 1651cbf3b02..4738294dbd9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3475,10 +3475,10 @@ GCC_PLUGIN_OPTION(PLUGIN_OPTION)
 AR_PLUGIN_OPTION=
 RANLIB_PLUGIN_OPTION=
 if test -n "$PLUGIN_OPTION"; then
-  if $AR --help 2>&1 | grep -q "\--plugin"; then
+  if $AR --help 2>&1 | grep -q "[-]-plugin"; then
     AR_PLUGIN_OPTION="$PLUGIN_OPTION"
   fi
-  if $RANLIB --help 2>&1 | grep -q "\--plugin"; then
+  if $RANLIB --help 2>&1 | grep -q "[-]-plugin"; then
     RANLIB_PLUGIN_OPTION="$PLUGIN_OPTION"
   fi
 else
diff --git a/libiberty/configure.ac b/libiberty/configure.ac
index 6c1ff9c6093..28933d5fcc1 100644
--- a/libiberty/configure.ac
+++ b/libiberty/configure.ac
@@ -116,11 +116,11 @@ AC_CHECK_TOOL(RANLIB, ranlib, :)
 
 GCC_PLUGIN_OPTION(PLUGIN_OPTION)
 if test -n "$PLUGIN_OPTION"; then
-  if $AR --help 2>&1 | grep -q "\--plugin"; then
+  if $AR --help 2>&1 | grep -q "[-]-plugin"; then
     AR_PLUGIN_OPTION="$PLUGIN_OPTION"
     AC_SUBST(AR_PLUGIN_OPTION)
   fi
-  if $RANLIB --help 2>&1 | grep -q "\--plugin"; then
+  if $RANLIB --help 2>&1 | grep -q "[-]-plugin"; then
     RANLIB_PLUGIN_OPTION="$PLUGIN_OPTION"
     AC_SUBST(RANLIB_PLUGIN_OPTION)
   fi
-- 
2.37.1


[-- Attachment #4: binutils-gdb-fedora-x86-64-32.txt.gz --]
[-- Type: application/gzip, Size: 52383 bytes --]