From: Simon Marchi <simon.marchi@polymtl.ca>
To: Ruslan Kabatsayev <b7.10110111@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Align natural-format register values to the same column
Date: Wed, 26 Jul 2017 11:33:00 -0000 [thread overview]
Message-ID: <955125f2e8963cb7cbd603e7ce427789@polymtl.ca> (raw)
In-Reply-To: <234e1432-11fe-0362-41cf-1096dfb38b9b@gmail.com>
On 2017-07-26 12:49, Ruslan Kabatsayev wrote:
>>> @@ -2280,9 +2289,15 @@ default_print_one_register_info (struct
>>> ui_file
>>> *file,
>>> {
>>> struct type *regtype = value_type (val);
>>> int print_raw_format;
>>> + string_file format_stream;
>>> + enum tab_stops
>>> + {
>>> + value_column_1=15,
>>> + value_column_2=32,
>>
>> Perhaps those could have more explicit names, like "column_hex" and
>> "column_natural"?
> This was my first thought, but then I noticed that for floating-point
> registers we have "(raw 0x....)" on the right column and "1.32536e+52"
> on the left one. Do you still think it's OK to name the left column hex
> and the right one natural?
Ah I see. Well that seems inconsistent, I wonder if there's a reason
it's this way. In that case, I'm fine with the names.
Simon
prev parent reply other threads:[~2017-07-26 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 7:54 Ruslan Kabatsayev
2017-07-26 9:33 ` Simon Marchi
2017-07-26 10:49 ` Ruslan Kabatsayev
2017-07-26 11:33 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=955125f2e8963cb7cbd603e7ce427789@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=b7.10110111@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox