From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117772 invoked by alias); 26 Jul 2017 11:33:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116058 invoked by uid 89); 26 Jul 2017 11:33:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 11:33:40 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v6QBXX0F023428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 26 Jul 2017 07:33:38 -0400 Received: by simark.ca (Postfix, from userid 112) id A2E1B1E98E; Wed, 26 Jul 2017 07:33:33 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 171561E056; Wed, 26 Jul 2017 07:33:32 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 26 Jul 2017 11:33:00 -0000 From: Simon Marchi To: Ruslan Kabatsayev Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Align natural-format register values to the same column In-Reply-To: <234e1432-11fe-0362-41cf-1096dfb38b9b@gmail.com> References: <1501055625-25029-1-git-send-email-b7.10110111@gmail.com> <5bce7397bf829abb601f61f6e40877c8@polymtl.ca> <234e1432-11fe-0362-41cf-1096dfb38b9b@gmail.com> Message-ID: <955125f2e8963cb7cbd603e7ce427789@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 26 Jul 2017 11:33:33 +0000 X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00410.txt.bz2 On 2017-07-26 12:49, Ruslan Kabatsayev wrote: >>> @@ -2280,9 +2289,15 @@ default_print_one_register_info (struct >>> ui_file >>> *file, >>> { >>> struct type *regtype = value_type (val); >>> int print_raw_format; >>> + string_file format_stream; >>> + enum tab_stops >>> + { >>> + value_column_1=15, >>> + value_column_2=32, >> >> Perhaps those could have more explicit names, like "column_hex" and >> "column_natural"? > This was my first thought, but then I noticed that for floating-point > registers we have "(raw 0x....)" on the right column and "1.32536e+52" > on the left one. Do you still think it's OK to name the left column hex > and the right one natural? Ah I see. Well that seems inconsistent, I wonder if there's a reason it's this way. In that case, I'm fine with the names. Simon