From: Luis Machado <luis.machado@linaro.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix/Update misc comments
Date: Thu, 09 Jan 2020 15:38:00 -0000 [thread overview]
Message-ID: <94f2157f-4a2a-5d7b-7aa8-b557e01e8f6d@linaro.org> (raw)
In-Reply-To: <87d0bsr6cz.fsf@tromey.com>
On 1/9/20 12:34 PM, Tom Tromey wrote:
>>>>>> "Luis" == Luis Machado <luis.machado@linaro.org> writes:
>
> Luis> How does it look?
>
> It seems reasonable to me. Probably Pedro should review it though.
>
Thanks.
> Luis> /* If this system does not support PT_STEP, a higher level
> Luis> - function will have called single_step() to transmute the step
> Luis> - request into a continue request (by setting breakpoints on
> Luis> + function will have called the appropriate functions to transmute the
> Luis> + step request into a continue request (by setting breakpoints on
>
> Is single_step not actually the function in question here?
>
That's the confusing part. There is a single_step (...) function for
gdbserver linux-low, but i don't see such a function for gdb.
So this reference looks stale to me.
> Tom
>
next prev parent reply other threads:[~2020-01-09 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 14:36 Luis Machado
2020-01-09 15:36 ` Tom Tromey
2020-01-09 15:38 ` Luis Machado [this message]
2020-01-09 18:54 ` Tom Tromey
2020-01-09 19:48 ` Pedro Alves
2020-01-09 23:26 ` Luis Machado
2020-01-09 23:26 ` [PATCH, v2] " Luis Machado
2020-01-13 20:03 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f2157f-4a2a-5d7b-7aa8-b557e01e8f6d@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox