From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8575 invoked by alias); 9 Jan 2020 15:38:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8307 invoked by uid 89); 9 Jan 2020 15:38:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qv1-f67.google.com Received: from mail-qv1-f67.google.com (HELO mail-qv1-f67.google.com) (209.85.219.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2020 15:38:41 +0000 Received: by mail-qv1-f67.google.com with SMTP id f16so3124566qvi.4 for ; Thu, 09 Jan 2020 07:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BkQkXd0eJFKEt9qYDBSV6TT+lrXvYh0IBHL/Pzx7zmc=; b=UEediTmAufDwEoXEotIGgFRbQe9EEI694eS3wtMh7XrRObeeenqc2iRPYfA0qAxotC CrSMBYKYH9FTH6OYXQ2EIiu5NX/aIpsmT3baeUKbsJwIYuogHAJMl7PnsEszFKJ1IRDN 0OskT2XvyfX+OvAktwZgNzYp+F/roGXUSjAtRvLXLbjuKmanc+q6D0miVmHh1/8M70UW p0DiALfhjArp8vaekP6imlcYvlJD1XEKUldebg/FvDVCnjFVn07lpEW5rKN0tWvcRK7s Q6ts5eapFxK4pA7BL3c9VqlnIrXHpkJM+ulYE2jBAXOIFsx6GIyC8t6eQQwTyMVlkc1+ 9xFQ== Return-Path: Received: from [192.168.0.185] ([177.158.86.92]) by smtp.gmail.com with ESMTPSA id o16sm3038805qkj.91.2020.01.09.07.38.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2020 07:38:39 -0800 (PST) Subject: Re: [PATCH] Fix/Update misc comments To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200106143620.2881-1-luis.machado@linaro.org> <87d0bsr6cz.fsf@tromey.com> From: Luis Machado Message-ID: <94f2157f-4a2a-5d7b-7aa8-b557e01e8f6d@linaro.org> Date: Thu, 09 Jan 2020 15:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <87d0bsr6cz.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00204.txt.bz2 On 1/9/20 12:34 PM, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado writes: > > Luis> How does it look? > > It seems reasonable to me. Probably Pedro should review it though. > Thanks. > Luis> /* If this system does not support PT_STEP, a higher level > Luis> - function will have called single_step() to transmute the step > Luis> - request into a continue request (by setting breakpoints on > Luis> + function will have called the appropriate functions to transmute the > Luis> + step request into a continue request (by setting breakpoints on > > Is single_step not actually the function in question here? > That's the confusing part. There is a single_step (...) function for gdbserver linux-low, but i don't see such a function for gdb. So this reference looks stale to me. > Tom >