Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Omair Javaid <omair.javaid@linaro.org>
Cc: Yao Qi <qiyaoltc@gmail.com>,
	GDB Patches <gdb-patches@sourceware.org>,
	       Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 0/3 v3] [AArch64] Support tagged pointer
Date: Wed, 11 Apr 2018 02:46:00 -0000	[thread overview]
Message-ID: <949e7a0c9b7fa2bdffa7cc0b9ee6132c@polymtl.ca> (raw)
In-Reply-To: <CANW4E-1-165=L2_xtQJVEohPZ-xL5i25ftB-2znghdXWa_Nffg@mail.gmail.com>

On 2018-04-10 20:36, Omair Javaid wrote:
>> This patch has broken kernel debugging using kgdb and openOCD.
>> 
>> Tagged address should only be considered while debugging only 
>> user-space
>> programs on linux.
>> 
>> I still need to understand the full background behind this patch but 
>> can
>> we pull it out of 8.1 release to make sure kernel debugging works?
>> 
>> 
> Just found out that patch series posted here
> https://sourceware.org/ml/gdb-patches/2017-12/msg00160.html does change
> aarch64-linux-tdep only.
> But the committed version here
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=a738ea1d41daeec0cccb4ab6671f4f6d53bd9e18
> is
> applying it to aarch64-tdep

I think it was because of Pedro's suggestion in this reply:
https://sourceware.org/ml/gdb-patches/2017-12/msg00179.html

although there was now acknowledgement from Yao, so I can only guess.

As Pedro said, it's the hardware that ignores these top bits.  But it 
first has to be configured to do so, so we can't assume that all aarch64 
code behaves like this.  So far we only know that the Linux userspace 
threads work like that, so I think it would make sense to move it to 
aarch64-linux-tdep.c.  Did you confirm that it indeed fixes your 
problem?

I could see a fix for this getting into the 8.1 branch (not reverting 
the patch though).

Simon


  reply	other threads:[~2018-04-11  2:46 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 10:04 Yao Qi
2017-12-08 10:04 ` [PATCH 3/3] Clear non-significant bits of address in watchpoint Yao Qi
2017-12-08 12:23   ` Pedro Alves
2017-12-08 10:04 ` [PATCH 2/3] Adjust breakpoint address by clearing non-significant bits Yao Qi
2017-12-08 12:22   ` Pedro Alves
2017-12-08 10:04 ` [PATCH 1/3] Clear non-significant bits of address on memory access Yao Qi
2017-12-08 12:22   ` Pedro Alves
2017-12-08 15:13     ` Ulrich Weigand
2017-12-08 15:36       ` Yao Qi
2017-12-19 13:50   ` Ulrich Weigand
2017-12-19 15:41     ` Yao Qi
2017-12-19 16:15       ` Ulrich Weigand
2017-12-20  9:57         ` Yao Qi
2017-12-20 13:03           ` [pushed] Fix Cell/B.E. regression (Re: [PATCH 1/3] Clear non-significant bits of address on memory access) Ulrich Weigand
2017-12-20 13:59             ` Yao Qi
2017-12-08 12:24 ` [PATCH 0/3 v3] [AArch64] Support tagged pointer Pedro Alves
2017-12-08 17:31 ` Yao Qi
2018-04-11  0:16   ` Omair Javaid
2018-04-11  0:37     ` Omair Javaid
2018-04-11  2:46       ` Simon Marchi [this message]
2018-04-11 10:14     ` Pedro Alves
2018-04-11 11:13       ` Omair Javaid
2018-04-11 11:19         ` Pedro Alves
2018-04-11 12:01           ` Omair Javaid
2018-04-11 18:27             ` Pedro Alves
2018-04-16  1:36               ` Omair Javaid
2018-04-16 22:57                 ` Pedro Alves
2018-04-20 14:34                   ` Omair Javaid
2018-04-20 16:13                     ` Daniel Thompson
2018-04-23  7:50                       ` Omair Javaid
2018-04-24 11:39                         ` Pedro Alves
2018-04-24 15:44                           ` Daniel Thompson
2018-04-24 11:48                     ` Pedro Alves
2018-04-24 16:05                       ` Daniel Thompson
2018-04-24 23:42                         ` Omair Javaid
2018-04-25  0:09                           ` Andrew Pinski
2018-04-25  8:04                           ` Daniel Thompson
2018-04-26  8:11                             ` Omair Javaid
2018-04-27 16:29                               ` Daniel Thompson
2018-04-30 13:42                                 ` Omair Javaid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=949e7a0c9b7fa2bdffa7cc0b9ee6132c@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=omair.javaid@linaro.org \
    --cc=palves@redhat.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox