From: Tom de Vries <tdevries@suse.de>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/contrib] Make gdb-add-index.sh shellcheck-clean
Date: Wed, 23 Sep 2026 09:19:30 +0200 [thread overview]
Message-ID: <939b163d-9438-4700-b29e-9945a316a5bc@suse.de> (raw)
In-Reply-To: <9368e2a9-ea97-4306-b081-33b81d181d28@suse.de>
On 9/23/26 12:27 AM, Tom de Vries wrote:
> I'll try to come up with something else.
I found a solution:
...
+cleanup ()
+{
+ for f in "$file" "$dwz_file"; do
+ if [ "$f" = "" ]; then
+ continue
+ fi
+ set_files "$f"
+ rm -f \
+ "$index4" \
+ "$index5" \
+ "$debugstr" \
+ "$debugstrmerge" \
+ "$debugstrerr"
+ done
+}
...
Rather than collecting the files into a list, and using the list for the
cleanup, use them directly in a cleanup function.
Submitted as v2 here (
https://sourceware.org/pipermail/gdb-patches/2026-September/230559.html ).
Thanks,
- Tom
prev parent reply other threads:[~2026-09-23 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 17:14 Tom de Vries
2026-09-22 20:13 ` Keith Seitz
2026-09-22 22:27 ` Tom de Vries
2026-09-23 7:19 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=939b163d-9438-4700-b29e-9945a316a5bc@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox