From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FES+JqV9s2pLbjYAWB0awg (envelope-from ) for ; Wed, 23 Sep 2026 03:20:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GAh/FHn3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Mlg7/7sK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=U3EIUXWT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pz0UXDv0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8B0381E033; Wed, 23 Sep 2026 03:20:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DDDCE1E033 for ; Wed, 23 Sep 2026 03:20:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A07FC4BB1C0E for ; Wed, 23 Sep 2026 07:20:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A07FC4BB1C0E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GAh/FHn3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Mlg7/7sK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=U3EIUXWT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pz0UXDv0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 702174B9DB79 for ; Wed, 23 Sep 2026 07:19:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 702174B9DB79 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 702174B9DB79 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790147980; cv=none; b=qH3wpxtrqI71Mg7x9PASv2J/SLvIpw9WJkmVynHGdaxgEru1LWYPduyTcVBn6uKyojp19Z5Hbz1089uKs/TnnyWoS3NtE/rVXGTd69+IUVNMpjkvKKM/PdaS62m0uBB72YpxsrN584lQ1UeVnFbKUE4l0Lj7p1Ql+GLo7MTV9yo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790147980; c=relaxed/simple; bh=oRyROr77c+ZSoJpksxuj63CxqNDYeG4O6k0V2EeF+2M=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=yCaQ0W28hUnUZsbCsLvNkEWG/RCVu4uzjB7b4iJk88rhsGRC5kkMEEBGU+DnZY+tVrnr32hAlMVqJyaBZ4cP6sqrhLLzd6Jsg0O1Y6GF/oJbFUQZ6JSq9q+4xiugXf5YMwO0MFJqiipLyFuYyMvQdndZYslGv2AK1SswrSyXHTA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GAh/FHn3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Mlg7/7sK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=U3EIUXWT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pz0UXDv0 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 702174B9DB79 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0190F1F8B9; Wed, 23 Sep 2026 07:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790147975; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZesT8XwYXh9dbJKoWHcEP6e3IqswHNYiGfyjADgOxm8=; b=GAh/FHn3nfiAqvFC2KfGgqRhi3GNaRyjI+w1bvpWlYKI6KmxS9avdTDoby6zZSKfF9jtZy 33Coyx4qWMHtV5PXMr7HRhmAVIdJSNbM9Vlil8Mwk8XQgqMSnNwDdlXPJ6UCRSp4IGP9x5 rCDvirQrtMtsR4PQNMj2VqxCOydGniU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790147975; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZesT8XwYXh9dbJKoWHcEP6e3IqswHNYiGfyjADgOxm8=; b=Mlg7/7sKwTpTsq0dHpxJbs+Qt9JxYWlEX3Pe3CU3C+qbk9BR/7anIXhoEbTIAunMbCBzDP QqE6yknsZQiylcBQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790147971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZesT8XwYXh9dbJKoWHcEP6e3IqswHNYiGfyjADgOxm8=; b=U3EIUXWTrHXfJFWjiuI3NfelCVm86f52JFIQhuFVPZLCLMR+pX+TuLaMiD201TIqSkD95W NUuRpsWScnuJhQN7Tmgdld0Bw/+qzG/E+ul5J/+NvZfqlVUt89TmajpOViMVyhJFZquzG6 uLQ8pObFIGMLi87/B003pa01Fak86Qw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790147971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZesT8XwYXh9dbJKoWHcEP6e3IqswHNYiGfyjADgOxm8=; b=pz0UXDv02S4oBTQqwwXE8Wuh9KBEMSLiaf+3s2qfb+hqYn7kdy6HALiMPztX4oKHtafRIO SghQxSya/H20iqAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BDFE4139E9; Wed, 23 Sep 2026 07:19:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0JtaHIJ9s2pYWwAAD6G6ig (envelope-from ); Wed, 23 Sep 2026 07:19:30 +0000 Message-ID: <939b163d-9438-4700-b29e-9945a316a5bc@suse.de> Date: Wed, 23 Sep 2026 09:19:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/contrib] Make gdb-add-index.sh shellcheck-clean From: Tom de Vries To: Keith Seitz , gdb-patches@sourceware.org References: <20260915171459.2753844-1-tdevries@suse.de> <9368e2a9-ea97-4306-b081-33b81d181d28@suse.de> Content-Language: en-US In-Reply-To: <9368e2a9-ea97-4306-b081-33b81d181d28@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.993]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url, imap1.dmz-prg2.suse.org:helo, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/23/26 12:27 AM, Tom de Vries wrote: > I'll try to come up with something else. I found a solution: ... +cleanup () +{ + for f in "$file" "$dwz_file"; do + if [ "$f" = "" ]; then + continue + fi + set_files "$f" + rm -f \ + "$index4" \ + "$index5" \ + "$debugstr" \ + "$debugstrmerge" \ + "$debugstrerr" + done +} ... Rather than collecting the files into a list, and using the list for the cleanup, use them directly in a cleanup function. Submitted as v2 here ( https://sourceware.org/pipermail/gdb-patches/2026-September/230559.html ). Thanks, - Tom