Re: [PATCH] Apply substitute-path to relative filenames as well

[LRN <lrn1986@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1614 bytes --]

On 28.03.2019 0:36, Tom Tromey wrote:
> LRN writes:
> 
>> Hey, it's been a week. Do i need to do something to move this along? (Please,
>> don't say "test case" :( )
> 
> Is it possible to write one?  I didn't think about it in detail.
> 
> I see there are already tests in gdb.base/subst.exp.  Perhaps it could
> be extended?

These tests only test the interactive output of gdb with regards to subst
commands. I.e. it issues a command, such as "show substitute-path", and then
matches the output to the one it expects.

My patch influences the output only when gdb is actually debugging something -
which means that the test must compile some program (using relative path to the
source file!), run it under gdb, set up a breakpoint, verify that the source
path printed at the breakpoint hit is relative (and unresolved - the test would
probably need to move the source file before running?), then use subst, then
probably restart and verify that the path is non-relative and resolved when the
same breakpoint hits.

Okay, maybe it can be done without breakpoints - just run and list
../../path/to/sourcefile.c:0 or something.

Anyway, that still sounds an order of magnitude more complicated that
subst.exp, so i would rather not try to implement all that using completely
unfamiliar testing framework that i do not have.

> 
> Also the review had a little nit that could be addressed.
> 

I did address it. The first follow-up[0] message had the new version of the
patch attached, with the nit fixed.

[0]: https://www.sourceware.org/ml/gdb-patches/2019-03/msg00082.html


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]