From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39821 invoked by alias); 27 Mar 2019 22:59:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39808 invoked by uid 89); 27 Mar 2019 22:59:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=H*RU:sk:broadba, HX-Spam-Relays-External:sk:broadba, H*r:sk:broadba X-HELO: mail-lj1-f196.google.com Received: from mail-lj1-f196.google.com (HELO mail-lj1-f196.google.com) (209.85.208.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Mar 2019 22:58:57 +0000 Received: by mail-lj1-f196.google.com with SMTP id v13so15915063ljk.4 for ; Wed, 27 Mar 2019 15:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:autocrypt:cc:subject:message-id:date:user-agent :mime-version:in-reply-to; bh=9S9RBkLxrgpL6KRVBViUSVWSz2wAywxO3pKgQfo+8dM=; b=FsqRFlvOVGQnVRh0jnwQ8qhA8pvLZNWnHwbUg6mbdcR0TmUJ1Ur5yIfhEgHcV0IQ5y 1pBvGpq5IwXtj0qecRD6U4ylY72vaaDmgyEgOwwnFHZRKFZsX6TEUgZEv6lbB08GHVrh Jz3ZP7fMJbfzz6UmnIc2p62Aiq2qaFytD7iNRQH7WYyT9RGntXAhv6gBrd4LvZYj6Kpg LN/HyDpELS0kYT3hzxk/nRrBhi/l7INUdRTjurNxtl8rvQsSnZXoFD3ga1xzMlkp+3yF Up57F6oSjdkppOtnl2/9JLnJ4SUxVSOhUgVHzVojRwdH7sfoeIlgiMLMEgB3HEZgwqDD fPjA== Return-Path: Received: from [192.168.4.39] (broadband-95-84-200-6.ip.moscow.rt.ru. [95.84.200.6]) by smtp.gmail.com with ESMTPSA id k90sm1428243ljb.89.2019.03.27.15.58.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 15:58:53 -0700 (PDT) To: gdb-patches@sourceware.org References: <5a785bba-7432-f6e0-1089-5d2bdd3450a3@gmail.com> <871s3lq8fy.fsf@tromey.com> <5415b22f-c46c-8dbf-4481-98be267e25bb@gmail.com> <87lg10knii.fsf@tromey.com> From: LRN Cc: tom@tromey.com Subject: Re: [PATCH] Apply substitute-path to relative filenames as well Message-ID: <931d12a3-41ad-af6a-6aef-d53ad149696a@gmail.com> Date: Wed, 27 Mar 2019 22:59:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87lg10knii.fsf@tromey.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2Kj1trNG2rg3x3j0GnnJTHllgolkqZhYN" X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00696.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Kj1trNG2rg3x3j0GnnJTHllgolkqZhYN Content-Type: multipart/mixed; boundary="u3K3pATj3Uu3Dp3oOYlEES3qTHPfuA45d"; protected-headers="v1" From: LRN To: gdb-patches@sourceware.org Cc: tom@tromey.com Message-ID: <931d12a3-41ad-af6a-6aef-d53ad149696a@gmail.com> Subject: Re: [PATCH] Apply substitute-path to relative filenames as well --u3K3pATj3Uu3Dp3oOYlEES3qTHPfuA45d Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1595 On 28.03.2019 0:36, Tom Tromey wrote: > LRN writes: >=20 >> Hey, it's been a week. Do i need to do something to move this along? (Pl= ease, >> don't say "test case" :( ) >=20 > Is it possible to write one? I didn't think about it in detail. >=20 > I see there are already tests in gdb.base/subst.exp. Perhaps it could > be extended? These tests only test the interactive output of gdb with regards to subst commands. I.e. it issues a command, such as "show substitute-path", and then matches the output to the one it expects. My patch influences the output only when gdb is actually debugging somethin= g - which means that the test must compile some program (using relative path to= the source file!), run it under gdb, set up a breakpoint, verify that the source path printed at the breakpoint hit is relative (and unresolved - the test w= ould probably need to move the source file before running?), then use subst, then probably restart and verify that the path is non-relative and resolved when= the same breakpoint hits. Okay, maybe it can be done without breakpoints - just run and list ../../path/to/sourcefile.c:0 or something. Anyway, that still sounds an order of magnitude more complicated that subst.exp, so i would rather not try to implement all that using completely unfamiliar testing framework that i do not have. >=20 > Also the review had a little nit that could be addressed. >=20 I did address it. The first follow-up[0] message had the new version of the patch attached, with the nit fixed. [0]: https://www.sourceware.org/ml/gdb-patches/2019-03/msg00082.html --u3K3pATj3Uu3Dp3oOYlEES3qTHPfuA45d-- --2Kj1trNG2rg3x3j0GnnJTHllgolkqZhYN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE4MWzR43wYaAzEA49ja3pJ2dZunQFAlycACYACgkQja3pJ2dZ unTQ5RAAqOyni8bdV3uFdbheF0Ddbu0+IdpJc3ypY45zZX2wegIhdM7OcNG+K16m fYAal+iC2MSx6nhPrjN5+SXjFKXZE77uTSQlgpWklQECFWALuAtLNyIElxmW8Tae iP6+c3RdSiv2L9401kXBQKkRySobnt9hQrxCu7ghvno7oRQQnzwdF6MmXS1jz3m0 6zS1jfAHnqfVqTF49BlVb9pAqsKu/+OdjLLkJFwXYsE89uLaXMP6DUy7leycy3wQ N+hAczsoCPjFDwYC/pGmmDSvbJvMUv84HMC0iBFgJurNnIUmaKK0Ws9ad95xzNUZ 9q+viJ6gZ5XPQBCymuFy5CFlPnwRSPzHNcH3DZGNV/1SpYcayrWQuD/6Qq/zQb6T qDfejngnxDFIaJv8pJS6bJQ2+snnJNR3AjfqjthruD5P36xen+a57t1QjTZ0Yg+b sxaB8IdXs4oY/h9mJnD6u6uDqVidY/U9zNKWIbCy1mVWhOD5JQcTNAxU9cVrc5Tz CHUL9pdE/nohEqF3pc8GCNYze3eDuQwAEoTGcbfVylT24zaBbHa5tQ6dw6s40YIt REtbvv+vmHT3M0n4kCrpZ/C9+lK+JQjNtwHYUwZD2tg8PX98Y1PAUhQaCKecVhQ2 pbQR2sCMAOyABfSu2nMSWCCWUSd06Dr81R06q1y32XPxy29TZqc= =Ot9e -----END PGP SIGNATURE----- --2Kj1trNG2rg3x3j0GnnJTHllgolkqZhYN--