Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simark@simark.ca>,
	Philippe Waroquiers <philippe.waroquiers@skynet.be>,
	gdb-patches@sourceware.org
Subject: Re: [RFA] Implement 'print -raw-values' and 'set print raw-values on|off'
Date: Wed, 04 Dec 2019 16:24:00 -0000	[thread overview]
Message-ID: <922dc754-deec-6650-f60e-7322599fc6c5@redhat.com> (raw)
In-Reply-To: <5b8685bb-465e-ef47-1dc0-0746f489f4f8@simark.ca>

On 12/4/19 3:43 AM, Simon Marchi wrote:
> On 2019-08-07 3:39 p.m., Philippe Waroquiers wrote:
>> The option framework documentation was speaking about a 'print -raw'
>> option, but this option does not exist.

Eh.  I think I recall that it would be a good idea to have it,
like I made "bt -full/-no-filters/-hide" options to
supersede "bt full/no-filters/hide", but then dropped it for some
reason.

So +1 from me.

(But see the other email I sent.)

>>
>> This patch implements -raw-values option that tells to ignore the
>> active pretty printers when printing a value.
>> As we already have -raw-frame-arguments, I thought -raw-values
>> was more clear, in particular to differentiate
>>    set print raw-values and set print raw-frame-arguments.
> 
> Hi Philippe,
> 
> I'm just a bit worried about the naming, but I don't have anything better
> to suggest.  I mention it in case you do.  The "set print raw-values" sounds
> like superset of "set print raw-frame-arguments", because in my mind frame
> arguments are printed as values.

But isn't it a superset?

> Other than that, the patch looks fine to me.

Thanks,
Pedro Alves


  reply	other threads:[~2019-12-04 16:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 19:39 Philippe Waroquiers
2019-08-07 21:38 ` Tom Tromey
2019-08-08 18:59   ` Philippe Waroquiers
2019-08-08 17:25 ` Eli Zaretskii
2019-09-07 11:42 ` PING " Philippe Waroquiers
2019-09-29 15:29 ` PING^2 " Philippe Waroquiers
2019-09-29 15:33   ` Eli Zaretskii
2019-09-29 15:49     ` Philippe Waroquiers
2019-10-20 10:26   ` PING^3 " Philippe Waroquiers
2019-12-04 16:18     ` Pedro Alves
2019-12-04  3:43 ` Simon Marchi
2019-12-04 16:24   ` Pedro Alves [this message]
2019-12-04 16:34     ` Simon Marchi
2019-12-04 17:19       ` Pedro Alves
2019-12-07 14:01         ` Philippe Waroquiers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=922dc754-deec-6650-f60e-7322599fc6c5@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox