Re: PING^3 Re: [RFA] Implement 'print -raw-values' and 'set print raw-values on|off'

[Pedro Alves <palves@redhat.com>]

On 10/20/19 11:26 AM, Philippe Waroquiers wrote:
> --- a/gdb/printcmd.c
> +++ b/gdb/printcmd.c
> @@ -1152,6 +1152,9 @@ print_command_parse_format (const char **expp, const char *cmdname,
>  {
>    const char *exp = *expp;
>  
> +  /* opts->raw value might already have been set by 'set print raw-values'
> +     or by using 'print -raw-values'.
> +     So, do not set opts->raw to 0, only set it to 1 if /r is given.  */
>    if (exp && *exp == '/')

Given this ...

> diff --git a/gdb/testsuite/gdb.python/py-prettyprint.exp b/gdb/testsuite/gdb.python/py-prettyprint.exp
> index 82e7e65031..3d88f7e9f2 100644
> --- a/gdb/testsuite/gdb.python/py-prettyprint.exp
> +++ b/gdb/testsuite/gdb.python/py-prettyprint.exp
> @@ -199,3 +199,13 @@ gdb_test_no_output "python enable_lookup_function ()"
>  
>  gdb_test "print ss" " = a=< a=<1> b=<$hex>> b=< a=<2> b=<$hex>>" \
>      "print ss enabled #2"
> +
> +gdb_test "print -raw-values -- ss" " = {a = {a = 1, b = $hex}, b = {a = 2, b = $hex}}" \
> +    "print -raw-values -- ss"
> +
> +gdb_test "print -raw-values on -- ss" " = {a = {a = 1, b = $hex}, b = {a = 2, b = $hex}}" \
> +    "print -raw-values on -- ss"
> +

... could you add some tests combining /r and -raw-values, to show & exercise
what the comment above means?

Thanks,
Pedro Alves