Re: [PATCH][gdb/symtab] Make gold index workaround more precise

[Tom de Vries <tdevries@suse.de>]

On 26-05-2020 15:01, Tom de Vries wrote:
> [ was: Re: [PATCH][gdb/symtab] Handle .gdb_index in ada language mode ]
> On 22-05-2020 22:31, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> Using this patch, I managed to get it working.
>>
>> Wow, cool.
>>
>> Tom> The patch does the following:
>> Tom> - enable ada .gdb_index by removing the ada check in write_psymbols
>> Tom> - copy some ada-specific code from debug_names::insert to
>> Tom>   write_psymbols
>> Tom> - disable a workaround for gold/15646 in dw2_expand_marked_cus
>>
>> Tom> As for the disabled workaround, I ran into trouble in
>> Tom> gdb.ada/access_tagged_param.exp, where setting a breakpoint on foo failed.
>>
>> Tom> The index shows that there are two entries for foo, one variable, one
>> Tom> function:
>> Tom> ...
>> Tom> [3733] foo:
>> Tom>         3 [global, variable]
>> Tom>         5 [global, function]
>> Tom> ...
>> Tom> The workaround skips the function, so disabling the workaround allows
>> Tom> the test to pass (my guess atm is that the workaround is not precise
>> Tom> enough).
>>
>> Looking at the gold bug, I suspect what's needed is to rule out
>> duplicates that have the same kind.
>>
> 
> I've:
> - committed a target board gold-gdb-index
> - committed a test-case for the workaround
>   (gdb.base/gold-gdb-index.exp), and
> - wrote a patch to make the duplicate check more precise (attached
>   below).
> 
> Any comments?

I tested this further in combination with the ada .gdb_index enabling,
and ran into failures in gdb.ada/bp_inlined_func.exp, which I managed to
fix by skipping the workaround when symbol_kind == function.

At this point, I wonder, should we just enable this workaround for
symbol_kind == type?

Thanks,
- Tom