Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Make gold index workaround more precise
Date: Wed, 27 May 2020 09:21:04 -0600	[thread overview]
Message-ID: <87o8q9pfof.fsf@tromey.com> (raw)
In-Reply-To: <d91fb436-623d-34f9-fe8b-d5cf82575b0e@suse.de> (Tom de Vries's message of "Tue, 26 May 2020 15:01:58 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> +  bool global_seen[NR_GDB_INDEX_SYMBOL_KINDS];

This can probably just use {} to initialize.

Tom> +  for (unsigned i = 0; i < NR_GDB_INDEX_SYMBOL_KINDS; ++i)
Tom> +    iter->global_seen[i] = false;

Then this wouldn't be needed.

Tom> +  bool global_seen[NR_GDB_INDEX_SYMBOL_KINDS];
Tom>    mapped_index &index = *dwarf2_per_objfile->index_table;
 
Tom> +  for (unsigned i = 0; i < NR_GDB_INDEX_SYMBOL_KINDS; ++i)
Tom> +    global_seen[i] = false;

Here too.

Tom


  parent reply	other threads:[~2020-05-27 15:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13  9:41 [PATCH][gdb/symtab] Handle .gdb_index in ada language mode Tom de Vries
2020-05-19 20:32 ` Tom Tromey
2020-05-20  9:40   ` Tom de Vries
2020-05-22 20:31     ` Tom Tromey
2020-05-26 13:01       ` [PATCH][gdb/symtab] Make gold index workaround more precise Tom de Vries
2020-05-26 14:03         ` Tom de Vries
2020-05-27 15:22           ` Tom Tromey
2020-05-28 13:02             ` Tom de Vries
2020-05-27 15:21         ` Tom Tromey [this message]
2020-06-02 10:47       ` [PATCH][gdb/symtab] Handle .gdb_index in ada language mode Tom de Vries
2020-06-10 12:49         ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8q9pfof.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox