From: Tom de Vries <tdevries@suse.de>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb/contrib] Make gdb-add-index.sh shellcheck-clean
Date: Wed, 23 Sep 2026 20:48:16 +0200 [thread overview]
Message-ID: <92054251-756e-4eaf-b6a9-ee13924c9738@suse.de> (raw)
In-Reply-To: <2d593033-4995-4ba0-8952-be58a8932bcd@redhat.com>
On 9/23/26 5:21 PM, Keith Seitz wrote:
> Hi,
>
> On 9/23/26 12:13 AM, Tom de Vries wrote:
>> diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh
>> index 4a30c5c5536..0c7797d23ed 100755
>> --- a/gdb/contrib/gdb-add-index.sh
>> +++ b/gdb/contrib/gdb-add-index.sh
>> @@ -93,10 +93,11 @@ if test $# != 1; then
>> fi
>> file="$1"
>> +set --
>
> Does this "set --" accomplish anything anymore?
>
Yes. The idea was to drop the arguments once we don't need them
anymore, to make sure subsequent $1 usage doesn't work anymore, and
we're forced use $file instead.
I've added a comment about that:
...
file="$1"
+
+# All arguments have been processed, there's no need to have them
+# around anymore.
set --
...
and pushed.
> Otherwise, everything looks good. Thank you!
>
Thanks for the reviews.
- Tom
> Reviewed-By: Keith Seitz <keiths@redhat.com>
>
> Keith
>
prev parent reply other threads:[~2026-09-23 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 7:13 Tom de Vries
2026-09-23 15:21 ` Keith Seitz
2026-09-23 18:48 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92054251-756e-4eaf-b6a9-ee13924c9738@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox