From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2JUaOhQftGpNsDgAWB0awg (envelope-from ) for ; Wed, 23 Sep 2026 14:48:52 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OHzRXyi1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0TUutb/P; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tuQB1S8j; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9f6pvegi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CE4CF1E01F; Wed, 23 Sep 2026 14:48:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 487B31E01F for ; Wed, 23 Sep 2026 14:48:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 022124BB3BCF for ; Wed, 23 Sep 2026 18:48:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 022124BB3BCF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OHzRXyi1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0TUutb/P; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tuQB1S8j; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9f6pvegi Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 896544BB24D1 for ; Wed, 23 Sep 2026 18:48:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 896544BB24D1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 896544BB24D1 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790189306; cv=none; b=h+gC9Bj88t9zRTzrPwf/V/0gTlf88vOdBZqG9Ve++f2szT/Wc091TnM1vWAJHxRYgiCL9IrII0UL6kcopQFf3YAzdtdVaLiMlharjrzGQr2ayp02gRlMlmNzSCFs+E/pmBBfgI0mpMqMZY3MG4gdLDy74jz0rpGMta6MpvZmnKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790189306; c=relaxed/simple; bh=K93vKyd38Fa0WO2c3LgTvpX3/wdGt6wdy9vk6aRic8o=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=FZyN28aLXLhyZGSub+59AXo1dv8gvwl4erwOS5ZCp99tFHTc436XUytb3jv1bJLgwpyEbVX1vWsSbVLCiCN1v9Ex2XiNDht0h6WuRgWvA0oGJzPixcsMgq5+AocVE0sMhTz99HUNvHyZ+PvXJc0qqyODDh2LfqoSTL8NtP+be7A= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OHzRXyi1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0TUutb/P; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tuQB1S8j; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9f6pvegi DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 896544BB24D1 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1D7181F45E; Wed, 23 Sep 2026 18:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790189301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tf3FITRIrQ4ScO7OW9xe/ZsF/ykx54CDdHPNzFIeMD4=; b=OHzRXyi1ZJJ008SRuUD1XCSG7GMgeBdbj6yWMoFiYgcEJDDas28nIYHOvBEZC6pQfkPbPy Un1VJBXDLf0fFeY5xmpl/N/suQGWONtRgxaWCxqOOo0YmCjoRX+xTNi5phQm2GyxTtWA+J x0LN3GA02qls1rcUy6tEMcGUZsHhUnM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790189301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tf3FITRIrQ4ScO7OW9xe/ZsF/ykx54CDdHPNzFIeMD4=; b=0TUutb/PFwzVl8ASnXr8qO8fnXBtzPAQhwwuLz5udR3g9AXctHztIFv3CANNjaArW7IMFX QZmxzRuKSbWhnyDg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tuQB1S8j; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9f6pvegi DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790189297; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tf3FITRIrQ4ScO7OW9xe/ZsF/ykx54CDdHPNzFIeMD4=; b=tuQB1S8jBbso1H167/+Wnc28fZaR+aBjX1E5DKZjEcO6YD0oGzkKAHyonJ2aiQiRX26E2Y xb+RvUmpzOulKx5icyzHLZ76E/8Khvc0SGU1Ec7uyLBBApuMiwuUoqGx3Qecvi0aAFsZSk hdbpGDVXqyeTsmP/3N9FAKTukZdeNaY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790189297; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tf3FITRIrQ4ScO7OW9xe/ZsF/ykx54CDdHPNzFIeMD4=; b=9f6pvegi3O4HFB9thfwdHQElcUn639hau0iEkhkGlT0ya315oi2aWm7nF7ZKD9SXFig0VC 414aMPbegxCz0ZCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DBEC8134E8; Wed, 23 Sep 2026 18:48:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gCCxKPAetGpnfwAAD6G6ig (envelope-from ); Wed, 23 Sep 2026 18:48:16 +0000 Message-ID: <92054251-756e-4eaf-b6a9-ee13924c9738@suse.de> Date: Wed, 23 Sep 2026 20:48:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/contrib] Make gdb-add-index.sh shellcheck-clean To: Keith Seitz , gdb-patches@sourceware.org References: <20260923071343.2887804-1-tdevries@suse.de> <2d593033-4995-4ba0-8952-be58a8932bcd@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <2d593033-4995-4ba0-8952-be58a8932bcd@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 1D7181F45E X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.de:dkim, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/23/26 5:21 PM, Keith Seitz wrote: > Hi, > > On 9/23/26 12:13 AM, Tom de Vries wrote: >> diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh >> index 4a30c5c5536..0c7797d23ed 100755 >> --- a/gdb/contrib/gdb-add-index.sh >> +++ b/gdb/contrib/gdb-add-index.sh >> @@ -93,10 +93,11 @@ if test $# != 1; then >>   fi >>   file="$1" >> +set -- > > Does this "set --" accomplish anything anymore? > Yes. The idea was to drop the arguments once we don't need them anymore, to make sure subsequent $1 usage doesn't work anymore, and we're forced use $file instead. I've added a comment about that: ... file="$1" + +# All arguments have been processed, there's no need to have them +# around anymore. set -- ... and pushed. > Otherwise, everything looks good. Thank you! > Thanks for the reviews. - Tom > Reviewed-By: Keith Seitz > > Keith >