Re: [PATCH v3 0/4] Allow loading symbol files with an offset

[Simon Marchi <simon.marchi@ericsson.com>]

On 2018-06-27 08:14 AM, Petr Tesarik wrote:
> Implement an "-o" option for symbol-file and add-symbol-file.
> 
> Changes since v2:
> * Fix the error message if add-symbol-file is called without arguments
> * Adjust texinfo description of add-symbol-file
> * Clarify the use of other_sections::sectindex
> * Use '.empty()' instead of '.size() == 0'
> * Split off set_objfile_default_section_offset
> 
> Changes since v1:
> * Adjust help texts
> * Update gdb/NEWS
> 
> Petr Tesarik (4):
>   Add an optional offset option to the "symbol-file" command
>   Make add-symbol-file's address argument optional
>   Make sure that sorting does not change section order
>   Add an optional offset option to the "add-symbol-file" command
> 
>  gdb/ChangeLog                       |  24 ++++++
>  gdb/NEWS                            |  10 +++
>  gdb/doc/ChangeLog                   |  13 ++++
>  gdb/doc/gdb.texinfo                 |  28 ++++---
>  gdb/symfile.c                       | 141 ++++++++++++++++++++++++++++++------
>  gdb/symfile.h                       |   4 +-
>  gdb/testsuite/ChangeLog             |  13 ++++
>  gdb/testsuite/gdb.base/relocate.exp |  95 ++++++++++++++++++++++++
>  8 files changed, 294 insertions(+), 34 deletions(-)
> 

Thanks Petr, this version LGTM.

Simon