From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24396 invoked by alias); 27 Jun 2018 12:57:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23699 invoked by uid 89); 27 Jun 2018 12:57:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:Unknown_Domain, Hx-spam-relays-external:Unknown_Domain X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 12:57:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1530104223; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oihJccQfPZpZC24q/uDMp4trcUdHB7WR82BjxxdBmFA=; b=ZCFjNGZ4jjdmvPVK9dZFKlXJQmrr1avY98qMTaqTLTBpdSQLRcjOnGW9B1tVK2PI 6ZCa82oOiiRuF4Ckwstm9MT00z1Spl1rBo9I/50zq9h0u2YYLJR7VzKxsozkPT+h z4sWcaqGsMCjosBxGXs855rhhK4qj1IkHpp6DTWIV2s=; Received: from ESESBMB504.ericsson.se (Unknown_Domain [153.88.183.117]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 83.64.31551.F99833B5; Wed, 27 Jun 2018 14:57:03 +0200 (CEST) Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 27 Jun 2018 14:57:03 +0200 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 27 Jun 2018 14:57:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KEQtuYOAufbJNkHhNslNK3QhIK3XzsU6U2FpsTThWqM=; b=jrIlMTYvldmOkb1UST6/JGm9nif0z4NeXADx9nQ613ctM45AdGRMZiwFCke/GHunuzjeHbx4MzMvd/ztH7Ja7ugXCIl3vjsSTVLCF3oohTwecVsxyQfHtQ120i+k2sg7S7moeJ8J3PbRNY4hbNjR3arr61kMbppus7KjYoEJJHI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.229.156] (129.192.64.65) by BYAPR15MB2391.namprd15.prod.outlook.com (2603:10b6:a02:8c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.24; Wed, 27 Jun 2018 12:56:59 +0000 Subject: Re: [PATCH v3 0/4] Allow loading symbol files with an offset To: Petr Tesarik , CC: Simon Marchi , Eli Zaretskii References: <20180611120835.27343-1-ptesarik@suse.cz> <20180627121429.16414-1-ptesarik@suse.cz> From: Simon Marchi Message-ID: <90d83cad-5f61-cac3-01fb-aa9a98ef3bde@ericsson.com> Date: Wed, 27 Jun 2018 12:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180627121429.16414-1-ptesarik@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00642.txt.bz2 On 2018-06-27 08:14 AM, Petr Tesarik wrote: > Implement an "-o" option for symbol-file and add-symbol-file. > > Changes since v2: > * Fix the error message if add-symbol-file is called without arguments > * Adjust texinfo description of add-symbol-file > * Clarify the use of other_sections::sectindex > * Use '.empty()' instead of '.size() == 0' > * Split off set_objfile_default_section_offset > > Changes since v1: > * Adjust help texts > * Update gdb/NEWS > > Petr Tesarik (4): > Add an optional offset option to the "symbol-file" command > Make add-symbol-file's address argument optional > Make sure that sorting does not change section order > Add an optional offset option to the "add-symbol-file" command > > gdb/ChangeLog | 24 ++++++ > gdb/NEWS | 10 +++ > gdb/doc/ChangeLog | 13 ++++ > gdb/doc/gdb.texinfo | 28 ++++--- > gdb/symfile.c | 141 ++++++++++++++++++++++++++++++------ > gdb/symfile.h | 4 +- > gdb/testsuite/ChangeLog | 13 ++++ > gdb/testsuite/gdb.base/relocate.exp | 95 ++++++++++++++++++++++++ > 8 files changed, 294 insertions(+), 34 deletions(-) > Thanks Petr, this version LGTM. Simon