From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Use std::vector for moribund_locations
Date: Wed, 11 Jul 2018 01:21:00 -0000 [thread overview]
Message-ID: <9068be05-25ef-d1f4-9f5a-bd85884ddc70@simark.ca> (raw)
In-Reply-To: <87sh4spc71.fsf@tromey.com>
On 2018-07-09 01:10 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> Just a note that this changes an "unordered remove" to an "ordered remove".
> Simon> If we don't need to keep the relative order of the remaining elements, it
> Simon> might be good performance-wise to keep the original behavior. This could
> Simon> be done by keeping the original code structure (iterating by index) and
> Simon> calling undordered_remove.
>
> How's this?
>
> Tom
LGTM!
Simon
prev parent reply other threads:[~2018-07-11 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 19:23 Tom Tromey
2018-07-03 14:46 ` Andrew Burgess
2018-07-04 4:51 ` Simon Marchi
2018-07-04 4:55 ` Tom Tromey
2018-07-04 17:39 ` Simon Marchi
2018-07-09 17:10 ` Tom Tromey
2018-07-11 1:21 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9068be05-25ef-d1f4-9f5a-bd85884ddc70@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox