From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28771 invoked by alias); 11 Jul 2018 01:21:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28750 invoked by uid 89); 11 Jul 2018 01:21:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:557 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jul 2018 01:21:10 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 49ED11E059; Tue, 10 Jul 2018 21:21:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531272068; bh=rdfxxcZ2dCTkdK0pQvaNT5scu1DaDWtfU/QhR5mJt/E=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=qbnKuTYX6RMaor09ahnqF6HPV3VsmW86CiO+MUT8M77MoAc1wHGXXd5ynjTRGrPNw ar9kkgJsb/xiKfMG231eySIfzfPE3K5Dq0f+lrtsNojRT911kfiHXpjINOcl6Kmkfl BPVHGCbOHEXIH7m+M3UzRlr+UgYaHqjqBp+A9BeQ= Subject: Re: [RFA] Use std::vector for moribund_locations To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20180605192346.5509-1-tom@tromey.com> <87sh4spc71.fsf@tromey.com> From: Simon Marchi Message-ID: <9068be05-25ef-d1f4-9f5a-bd85884ddc70@simark.ca> Date: Wed, 11 Jul 2018 01:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87sh4spc71.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00291.txt.bz2 On 2018-07-09 01:10 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Just a note that this changes an "unordered remove" to an "ordered remove". > Simon> If we don't need to keep the relative order of the remaining elements, it > Simon> might be good performance-wise to keep the original behavior. This could > Simon> be done by keeping the original code structure (iterating by index) and > Simon> calling undordered_remove. > > How's this? > > Tom LGTM! Simon