Re: [PATCH 0/4] Add another way to check for MTE-tagged addresses on remote targets

[Luis Machado <luis.machado@arm.com>]

Hi Gustavo,

On 3/28/24 07:00, Gustavo Romero wrote:
> This series introduces a new method to check for MTE-tagged addresses on
> remote targets.
> 
> A new remote packet, qMemTagAddrCheck, is introduced, along with a new
> remote feature associated with it, 'memory-tagging-check-add+'. Only
> when 'memory-tagging-check-add+' feature is advertised GDB will use the
> new packet to query if an address is tagged.
> 
> This new mechanism allows for checking MTE addresses in an OS-agnostic
> way, which is necessary when debugging targets that do not support
> '/proc/<PID>/smaps', as the current method of reading smaps contents
> fails in such cases.
> 
> Cheers,
> Gustavo
> 
> Gustavo Romero (4):
>   gdb: aarch64: Remove MTE address checking from get_memtag
>   gdb: aarch64: Move MTE address check out of set_memtag
>   gdb: aarch64: Remove MTE address checking from memtag_matches_p
>   gdb: Add new remote packet to check if address is tagged
> 
>  gdb/aarch64-linux-nat.c   |  8 +++++
>  gdb/aarch64-linux-tdep.c  | 22 +++-----------
>  gdb/arch-utils.c          |  2 +-
>  gdb/arch-utils.h          |  2 +-
>  gdb/corelow.c             |  8 +++++
>  gdb/gdbarch-gen.h         |  4 +--
>  gdb/gdbarch.c             |  2 +-
>  gdb/gdbarch_components.py |  2 +-
>  gdb/printcmd.c            | 29 +++++++++++-------
>  gdb/remote.c              | 62 +++++++++++++++++++++++++++++++++++++++
>  gdb/target-delegates.c    | 28 ++++++++++++++++++
>  gdb/target.c              |  6 ++++
>  gdb/target.h              |  6 ++++
>  13 files changed, 147 insertions(+), 34 deletions(-)
> 

Thanks for the series. Please bear with me while I go through it and try it on my end.