From: Gustavo Romero <gustavo.romero@linaro.org>
To: gdb-patches@sourceware.org
Cc: luis.machado@arm.com, thiago.bauermann@linaro.org,
gustavo.romero@linaro.org
Subject: [PATCH 2/4] gdb: aarch64: Move MTE address check out of set_memtag
Date: Thu, 28 Mar 2024 07:00:53 +0000 [thread overview]
Message-ID: <20240328070055.2578783-3-gustavo.romero@linaro.org> (raw)
In-Reply-To: <20240328070055.2578783-1-gustavo.romero@linaro.org>
Move MTE address check out of set_memtag and add this check to the
upper layer, before set_memtag is called. This is a preparation for
using a target hook instead of a gdbarch hook MTE address checks.
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
---
gdb/aarch64-linux-tdep.c | 4 ----
gdb/printcmd.c | 6 ++++++
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 50055ac3f48..8e6e63d4dcb 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -2525,10 +2525,6 @@ aarch64_linux_set_memtags (struct gdbarch *gdbarch, struct value *address,
/* Remove the top byte. */
addr = gdbarch_remove_non_address_bits (gdbarch, addr);
- /* Make sure we are dealing with a tagged address to begin with. */
- if (!aarch64_linux_tagged_address_p (gdbarch, address))
- return false;
-
/* With G being the number of tag granules and N the number of tags
passed in, we can have the following cases:
diff --git a/gdb/printcmd.c b/gdb/printcmd.c
index cb0d32aa4bc..ae4d640ccf2 100644
--- a/gdb/printcmd.c
+++ b/gdb/printcmd.c
@@ -3127,6 +3127,12 @@ memory_tag_set_allocation_tag_command (const char *args, int from_tty)
/* Parse the input. */
parse_set_allocation_tag_input (args, &val, &length, tags);
+ /* If the address is not in a region memory mapped with a memory tagging
+ flag, it is no use trying to manipulate its allocation tag. */
+ if (!gdbarch_tagged_address_p (current_inferior ()->arch (), val)) {
+ show_addr_not_tagged (value_as_address(val));
+ }
+
if (!gdbarch_set_memtags (current_inferior ()->arch (), val, length, tags,
memtag_type::allocation))
gdb_printf (_("Could not update the allocation tag(s).\n"));
--
2.34.1
next prev parent reply other threads:[~2024-03-28 7:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 7:00 [PATCH 0/4] Add another way to check for MTE-tagged addresses on remote targets Gustavo Romero
2024-03-28 7:00 ` [PATCH 1/4] gdb: aarch64: Remove MTE address checking from get_memtag Gustavo Romero
2024-03-28 7:00 ` Gustavo Romero [this message]
2024-03-28 7:00 ` [PATCH 3/4] gdb: aarch64: Remove MTE address checking from memtag_matches_p Gustavo Romero
2024-03-28 7:00 ` [PATCH 4/4] gdb: Add new remote packet to check if address is tagged Gustavo Romero
2024-03-28 13:00 ` [PATCH 0/4] Add another way to check for MTE-tagged addresses on remote targets Luis Machado
2024-03-28 22:59 ` Gustavo Romero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328070055.2578783-3-gustavo.romero@linaro.org \
--to=gustavo.romero@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox