Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Jim Blandy" <jimb@red-bean.com>
To: "Nick Roberts" <nickrob@snap.net.nz>
Cc: "Vladimir Prus" <ghost@cs.msu.su>, gdb-patches@sources.redhat.com
Subject: Re: Variable objects: references formatting
Date: Thu, 04 May 2006 17:32:00 -0000	[thread overview]
Message-ID: <8f2776cb0605041032g54a2a015hb4b8535d5cff5795@mail.gmail.com> (raw)
In-Reply-To: <17497.24251.518395.25087@farnswood.snap.net.nz>

On 5/3/06, Nick Roberts <nickrob@snap.net.nz> wrote:
>  > The patch is against an older version of varobj.c, and does seem to be
>  > cut from a larger patch, but it applies, and given the surrounding
>  > code in c_value_of_variable, and the behavior of c_val_print, the
>  > general sense of the change seems correct.  Have you tried creating
>  > varobjs for values that are references to structs and displaying them,
>  > which I think is the case actually being addressed?
>
> OK, if its a patch for -var-valuate-expression then perhaps the BOGUS
> comment could be removed as it seems to address this issue.

I read the "BOGUS" comment as referring to the fact that we have to
specially trap structs and unions, instead of simply passing
everything through common_val_print.  I don't think this patch affects
that "bogusness"; it just makes the workaround work better.

(Are there any cases where common_val_print (and thus c_val_print)
prints the "{...}" we need automatically for us?  Or is this code the
sole source of that behavior?)


  reply	other threads:[~2006-05-04 17:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-03 23:05 Nick Roberts
2006-05-03 23:50 ` Jim Blandy
2006-05-04  1:53   ` Nick Roberts
2006-05-04 17:32     ` Jim Blandy [this message]
2006-05-04 22:30       ` Nick Roberts
2006-05-05  8:08         ` Jim Blandy
2006-05-04  5:30 ` Vladimir Prus
2006-05-04  6:21   ` Nick Roberts
2006-05-04  7:00     ` Vladimir Prus
2006-05-04  7:20       ` Nick Roberts
2006-05-04 12:10         ` Vladimir Prus
2006-05-08 12:41           ` [PATCH] -var-update [was Re: Variable objects: references formatting] Nick Roberts
2006-05-08 17:27             ` Jim Blandy
2006-05-08 21:17               ` Nick Roberts
2006-05-15 16:54             ` Daniel Jacobowitz
2006-05-17  0:45               ` Nick Roberts
2006-05-17  1:28                 ` Daniel Jacobowitz
2006-05-17  1:43                   ` Nick Roberts
2006-05-17  3:39                     ` Daniel Jacobowitz
2006-05-19  7:41                       ` [PATCH] -var-update Nick Roberts
2006-05-19  9:47                         ` Vladimir Prus
  -- strict thread matches above, loose matches on Subject: below --
2006-05-03  9:22 Variable objects: references formatting Vladimir Prus
2006-05-03 17:50 ` Jim Blandy
2006-05-03 18:08   ` Jim Blandy
2006-05-04  5:19     ` Vladimir Prus
2006-05-04  6:08       ` Jim Blandy
2006-05-04  6:10         ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f2776cb0605041032g54a2a015hb4b8535d5cff5795@mail.gmail.com \
    --to=jimb@red-bean.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox