Re: [PATCH v3 3/3] gdb: extend the [[N]]::foo syntax for files

[Guinevere Larsen <guinevere@redhat.com>]

On 7/9/25 11:02 PM, Kevin Buettner wrote:
> Hi Gwen,
>
> On Thu, 19 Jun 2025 15:05:40 -0300
> Guinevere Larsen <guinevere@redhat.com> wrote:
>
>> diff --git a/gdb/parse.c b/gdb/parse.c
>> index 64653c8ae6e..6edd9058dcb 100644
>> --- a/gdb/parse.c
>> +++ b/gdb/parse.c
>> @@ -421,7 +421,8 @@ parse_exp_in_context (const char **stringptr,
>> CORE_ADDR pc,
>>     parser_state ps (lang, get_current_arch (), expression_context_block,
>>   		   expression_context_pc, flags, *stringptr,
>> -		   completer != nullptr, tracker);
>> +		   completer != nullptr, tracker,
>> +		   current_program_space->solib_ops ());
>>   
>>     scoped_restore_current_language lang_saver (lang->la_language);
>>   
> I'm seeing a build error related to the bit above:
>
> /mesquite2/sourceware-git/worktree-review/gdb/parse.c: In function
> ‘expression_up parse_exp_in_context(const char**, CORE_ADDR, const block*,
> parser_flags, innermost_block_tracker*,
> std::unique_ptr<expr_completion_base>*)’:
> /mesquite2/sourceware-git/worktree-review/gdb/parse.c:425:53: error:
> invalid conversion from ‘const solib_ops*’ to ‘solib_ops*’ [-fpermissive]
> 425 |                    current_program_space->solib_ops ()); |
>          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ |
>                        | |
>    const solib_ops* In file included from
> /mesquite2/sourceware-git/worktree-review/gdb/parse.c:41:
> /mesquite2/sourceware-git/worktree-review/gdb/parser-defs.h:152:28: note:
> initializing argument 9 of ‘parser_state::parser_state(const
> language_defn*, gdbarch*, const block*, CORE_ADDR, parser_flags, const
> char*, bool, innermost_block_tracker*, solib_ops*)’ 152 |
> solib_ops *ops) |                 ~~~~~~~~~~~^~~
>
> Kevin
>
Ah, thanks for reporting this, I must have not redone a build when I 
sent this (sorry, it was pre-vacation rush).

This is trivially solved by making all solib_ops pointers in 
parser_state const, I fixed it locally

-- 
Cheers,
Guinevere Larsen
She/Her/Hers