From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id k10IEo/Sb2iSrDAAWB0awg (envelope-from ) for ; Thu, 10 Jul 2025 10:47:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Nw+dnbtg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3146D1E11C; Thu, 10 Jul 2025 10:47:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C4F71E089 for ; Thu, 10 Jul 2025 10:47:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AB3DC385842D for ; Thu, 10 Jul 2025 14:47:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB3DC385842D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Nw+dnbtg Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 14A1D3858C56 for ; Thu, 10 Jul 2025 14:47:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14A1D3858C56 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14A1D3858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752158831; cv=none; b=PlOqKSbSQdJUFGeLXKB7krmR3jRe2NuQ166KvZR8dYBXQd/d8G0N03UZ3UaDAg8si0W1sLdF+4Ns4HPRcR4VYJChOPQWAdjyqz9DOJSn1D309To99adZ/RVVRk+rVCscLUPdYLJcd9KehOtccI4C3mnWjVmCH+aALiNQfsbvsg0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752158831; c=relaxed/simple; bh=rUU0J41s2Q97DPQiLI1HzjQR3myfhK1vDE8SHDcVRQ8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=e70wEXp3pCPyrwycORz1fv5C2dfgPWGZ8cv2KnZJc4kaNJ25JqgJay/A1Nni8j7hQce8pIZUnUbLOqApDNU1pD1u+MeYmP0RQg8LdqEwLWBa45hJ8H3/GEY/HqcprSSx0vk1rmoFyt2WTGVZfCGHvICnDzNtC3oWlJ3hkjC2LeI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14A1D3858C56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752158830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R2DIcDXQvICzNvi53lnpBN1phJnz0rYrsJ1L3Z8qqF0=; b=Nw+dnbtglcHn0RIfWvtglgEiMIRAzZttLtjDhnh18Yn/MJM6QvfHnEIXneVCuzN3P0/ZSK tdoHEJdGLyk+3GF92EoUg+ui5kejpBRrUGzdDVB1LTDZvC51liY/v/GllgnKoR5b3HSjz/ VLeXoxW9VFgwJO06Qcb1esEFpOFEIGc= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-7Sj5ljXsOwe-NtFLomr8fA-1; Thu, 10 Jul 2025 10:47:09 -0400 X-MC-Unique: 7Sj5ljXsOwe-NtFLomr8fA-1 X-Mimecast-MFC-AGG-ID: 7Sj5ljXsOwe-NtFLomr8fA_1752158829 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a9764b4dc9so19353281cf.2 for ; Thu, 10 Jul 2025 07:47:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752158829; x=1752763629; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R2DIcDXQvICzNvi53lnpBN1phJnz0rYrsJ1L3Z8qqF0=; b=ZU6jsZjNodnoXHdW9TC4sbZiIP0ITFa1v7bXOcOT9r/8GTv0NyfWLHuV6fxCM0Csjx NejBizGIg4ns+1087ll1XV7+v25/ojuXO0fJlrrHfLKVFAwIuoai1KiPLISl5+Y1sQJs Qo2QWX14dZPnpBXYu9RgOMCdcw7TTI2aQjy+Q35tx9Tpg66r3zkudU8OqdJTdMop9Zc9 HbhT2GlgsqzbPTVCnUn5D1PgVDQLbio6swm8tt76Fr4zXMKMZLDOyU0lOfDwq75FIj/q TscWLcYAasB+mHm6/sxWWxbyjMzIg9gAG/SH9LVq6QvUUdoBgvFXmgJdSHJMXPRT+ZX2 iJsA== X-Gm-Message-State: AOJu0YzNGF2wn4NFbxcZtxCLj8fn3RcUs3zCaTPWk1WMypcMvCOi+e8P mbEOgDx/CLtvKmYFdh+eZfExONvzKotUgZSlfCXRe9qI0ezWTC33G6FLhpeHBYFCClLkB+i9pmN AujYdxTEc1BStPquyARm+b3SOiJx2IQQ4puThYfGv9YAMyBuCLuaACPVwoYrxE9ZaTgytvjU= X-Gm-Gg: ASbGncuBRr9Q0W3N2EXDiCBB4tyU957X9RscrLPQnQ+KXQkMndDvbdSdrf6ujlLond1 xpYLcAb+JSch7B/fT/eCbLg9BvhugJ48fZjUc2VDSrlMwrvNAAUTD6T78pTzISIdTBSxwPWTuV2 z+o4dWcdvXxmq2D3ty23VznNmrPj/NP+91OQEgTkTj7+NVBiD2Batqcmny14+m7hj/NZ5kwSric C//YiJ96+BhrDmXWdQRR3Zl9flylQzmM2vrJBbSjyWZvdK/gSxbPmB8XZHZxm8oHi0gSngHogsI 9JdyeFhfHdcDh1WULt0+7jKU/KbviC0Zaw== X-Received: by 2002:a05:622a:2a0f:b0:4a8:2d24:72b3 with SMTP id d75a77b69052e-4a9ec8152c0mr51645171cf.39.1752158828301; Thu, 10 Jul 2025 07:47:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLjLsTk5vcckRHpFYJZD6mAEyrZdOheeXjaLvgC/WvH/vRWJ2+KYXi5H+WMqXl1yLz8BhJ4Q== X-Received: by 2002:a05:622a:2a0f:b0:4a8:2d24:72b3 with SMTP id d75a77b69052e-4a9ec8152c0mr51644501cf.39.1752158827722; Thu, 10 Jul 2025 07:47:07 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edea70e3sm9402151cf.55.2025.07.10.07.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jul 2025 07:47:07 -0700 (PDT) Message-ID: <8ed10634-662e-45fa-ae67-959b60aedd93@redhat.com> Date: Thu, 10 Jul 2025 11:47:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] gdb: extend the [[N]]::foo syntax for files To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20250619180540.2315103-1-guinevere@redhat.com> <20250619180540.2315103-4-guinevere@redhat.com> <20250709190226.41d1be21@f41-zbm-amd> From: Guinevere Larsen In-Reply-To: <20250709190226.41d1be21@f41-zbm-amd> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Sm_lwsSOO0anTIsSdIwo5KQY3_kCQdyU4-cAX75GgGI_1752158829 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/9/25 11:02 PM, Kevin Buettner wrote: > Hi Gwen, > > On Thu, 19 Jun 2025 15:05:40 -0300 > Guinevere Larsen wrote: > >> diff --git a/gdb/parse.c b/gdb/parse.c >> index 64653c8ae6e..6edd9058dcb 100644 >> --- a/gdb/parse.c >> +++ b/gdb/parse.c >> @@ -421,7 +421,8 @@ parse_exp_in_context (const char **stringptr, >> CORE_ADDR pc, >> parser_state ps (lang, get_current_arch (), expression_context_block, >> expression_context_pc, flags, *stringptr, >> - completer != nullptr, tracker); >> + completer != nullptr, tracker, >> + current_program_space->solib_ops ()); >> >> scoped_restore_current_language lang_saver (lang->la_language); >> > I'm seeing a build error related to the bit above: > > /mesquite2/sourceware-git/worktree-review/gdb/parse.c: In function > ‘expression_up parse_exp_in_context(const char**, CORE_ADDR, const block*, > parser_flags, innermost_block_tracker*, > std::unique_ptr*)’: > /mesquite2/sourceware-git/worktree-review/gdb/parse.c:425:53: error: > invalid conversion from ‘const solib_ops*’ to ‘solib_ops*’ [-fpermissive] > 425 | current_program_space->solib_ops ()); | > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ | > | | > const solib_ops* In file included from > /mesquite2/sourceware-git/worktree-review/gdb/parse.c:41: > /mesquite2/sourceware-git/worktree-review/gdb/parser-defs.h:152:28: note: > initializing argument 9 of ‘parser_state::parser_state(const > language_defn*, gdbarch*, const block*, CORE_ADDR, parser_flags, const > char*, bool, innermost_block_tracker*, solib_ops*)’ 152 | > solib_ops *ops) | ~~~~~~~~~~~^~~ > > Kevin > Ah, thanks for reporting this, I must have not redone a build when I sent this (sorry, it was pre-vacation rush). This is trivially solved by making all solib_ops pointers in parser_state const, I fixed it locally -- Cheers, Guinevere Larsen She/Her/Hers