[patch] document target sim args & arm options

[patch] document target sim args & arm options

[Matt Rice]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

this documents that the arm simulator has an option --swi-support
and that 'target sim' can accept arguments on behalf of the simulator
in the info and 'help target sim'

[-- Attachment #2: simargs.diff --]
[-- Type: application/octet-stream, Size: 1677 bytes --]

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 92a1237..cb90a87 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -14895,7 +14895,7 @@ useful if you have some other way of getting the stub to the target
 system, and you can put it somewhere in memory where it won't get
 clobbered by the download.
 
-@item target sim
+@item target sim @r{[}@var{simargs}@r{]} @r{...}
 @cindex built-in simulator target
 Builtin CPU simulator.  @value{GDBN} includes simulators for most architectures.
 In general,
@@ -17291,6 +17291,25 @@ well as the Angel monitor.
 Show the setting of RDI heartbeat packets.
 @end table
 
+@table @code
+@item target sim @r{[}@var{simargs}@r{]} @r{...}
+The @value{GDBN} ARM simulator accepts the following optional arguments.
+
+@table @code
+@item --swi-support=@var{type}
+Tell the simulator which SWI interfaces to support.
+@var{type} may be a comma separated list of the following values.
+The default value is @code{all}.
+
+@table @code
+@item none
+@item demon
+@item angel
+@item redboot
+@item all
+@end table
+@end table
+@end table
 
 @node M32R/D
 @subsection Renesas M32R/D and M32R/SDI
diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c
index 9f1adc7..96b45de 100644
--- a/gdb/remote-sim.c
+++ b/gdb/remote-sim.c
@@ -889,7 +889,7 @@ init_gdbsim_ops (void)
 {
   gdbsim_ops.to_shortname = "sim";
   gdbsim_ops.to_longname = "simulator";
-  gdbsim_ops.to_doc = "Use the compiled-in simulator.";
+  gdbsim_ops.to_doc = "Use the compiled-in simulator.  Any arguments will be passed on to the simulator.";
   gdbsim_ops.to_open = gdbsim_open;
   gdbsim_ops.to_close = gdbsim_close;
   gdbsim_ops.to_detach = gdbsim_detach;

Re: [patch] document target sim args & arm options

[Eli Zaretskii]

> Date: Fri, 26 Mar 2010 07:10:07 -0700
> From: Matt Rice <ratmice@gmail.com>
> 
> +@item target sim @r{[}@var{simargs}@r{]} @r{...}

This will look better if you use @dots{} instead of @r{...}.

Okay with this change.

Thanks.

Re: [patch] document target sim args & arm options

[Matt Rice]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On Fri, Mar 26, 2010 at 7:45 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 26 Mar 2010 07:10:07 -0700
>> From: Matt Rice <ratmice@gmail.com>
>>
>> +@item target sim @r{[}@var{simargs}@r{]} @r{...}
>
> This will look better if you use @dots{} instead of @r{...}.
>
> Okay with this change.

Thanks,

attached is an updated patch, also changing another occurance of @r{...}
forgot to mention i don't have commit access, there is a request in the queue,
so whatever is easiest.

[-- Attachment #2: simargs.diff --]
[-- Type: application/octet-stream, Size: 2105 bytes --]

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 4bef3f0..56dbe5d 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -3872,7 +3872,7 @@ A call to @code{exec}.  This is currently only available for HP-UX
 and @sc{gnu}/Linux.
 
 @item syscall
-@itemx syscall @r{[}@var{name} @r{|} @var{number}@r{]} @r{...}
+@itemx syscall @r{[}@var{name} @r{|} @var{number}@r{]} @dots{} 
 @cindex break on a system call.
 A call to or return from a system call, a.k.a.@: @dfn{syscall}.  A
 syscall is a mechanism for application programs to request a service
@@ -14899,7 +14899,7 @@ useful if you have some other way of getting the stub to the target
 system, and you can put it somewhere in memory where it won't get
 clobbered by the download.
 
-@item target sim
+@item target sim @r{[}@var{simargs}@r{]} @dots{}
 @cindex built-in simulator target
 Builtin CPU simulator.  @value{GDBN} includes simulators for most architectures.
 In general,
@@ -17295,6 +17295,25 @@ well as the Angel monitor.
 Show the setting of RDI heartbeat packets.
 @end table
 
+@table @code
+@item target sim @r{[}@var{simargs}@r{]} @dots{} 
+The @value{GDBN} ARM simulator accepts the following optional arguments.
+
+@table @code
+@item --swi-support=@var{type}
+Tell the simulator which SWI interfaces to support.
+@var{type} may be a comma separated list of the following values.
+The default value is @code{all}.
+
+@table @code
+@item none
+@item demon
+@item angel
+@item redboot
+@item all
+@end table
+@end table
+@end table
 
 @node M32R/D
 @subsection Renesas M32R/D and M32R/SDI
diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c
index 9f1adc7..96b45de 100644
--- a/gdb/remote-sim.c
+++ b/gdb/remote-sim.c
@@ -889,7 +889,7 @@ init_gdbsim_ops (void)
 {
   gdbsim_ops.to_shortname = "sim";
   gdbsim_ops.to_longname = "simulator";
-  gdbsim_ops.to_doc = "Use the compiled-in simulator.";
+  gdbsim_ops.to_doc = "Use the compiled-in simulator.  Any arguments will be passed on to the simulator.";
   gdbsim_ops.to_open = gdbsim_open;
   gdbsim_ops.to_close = gdbsim_close;
   gdbsim_ops.to_detach = gdbsim_detach;

Re: [patch] document target sim args & arm options

[Eli Zaretskii]

> Date: Fri, 26 Mar 2010 08:17:23 -0700
> From: Matt Rice <ratmice@gmail.com>
> Cc: gdb-patches@sourceware.org
> 
> On Fri, Mar 26, 2010 at 7:45 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> Date: Fri, 26 Mar 2010 07:10:07 -0700
> >> From: Matt Rice <ratmice@gmail.com>
> >>
> >> +@item target sim @r{[}@var{simargs}@r{]} @r{...}
> >
> > This will look better if you use @dots{} instead of @r{...}.
> >
> > Okay with this change.
> 
> Thanks,
> 
> attached is an updated patch, also changing another occurance of @r{...}

Thanks, this is fine.

Re: [patch] document target sim args & arm options

[Matt Rice]

On Fri, Mar 26, 2010 at 8:25 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> Thanks, this is fine.
>
spaced the changelog entries sorry.

2010-03-26  Matt Rice  <ratmice@gmail.com>

        * gdb.texinfo (ARM): Document target sim args.
        (Set Catchpoints): Use @dots{} instead of @r{...}.

2010-03-26  Matt Rice  <ratmice@gmail.com>

        * remote-sim.c (init_gdb_ops): Add help text about sim args.

Re: [patch] document target sim args & arm options

[Eli Zaretskii]

> Date: Fri, 26 Mar 2010 08:17:23 -0700
> From: Matt Rice <ratmice@gmail.com>
> Cc: gdb-patches@sourceware.org
> 
> attached is an updated patch, also changing another occurance of @r{...}
> forgot to mention i don't have commit access, there is a request in the queue,
> so whatever is easiest.

I committed the doc part for you, thanks.

I didn't commit the remote-sim.c part.  Did anyone approved that?