Re: [PATCH] gnulib: import sys_wait

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-09-04 3:41 a.m., Mike Frysinger wrote:
> On 03 Sep 2021 16:54, Simon Marchi wrote:
>> On 2021-06-13 1:25 a.m., Mike Frysinger via Gdb-patches wrote:
>>> A few sims use this to emulate process syscalls.
>>>  gnulib/Makefile.in               |   4 +
>>>  gnulib/aclocal.m4                |   1 +
>>>  gnulib/config.in                 |   3 +
>>>  gnulib/configure                 |  99 +++++++++++++++++++++++
>>>  gnulib/import/Makefile.am        |  29 +++++++
>>>  gnulib/import/Makefile.in        |  35 +++++++--
>>>  gnulib/import/m4/gnulib-cache.m4 |   2 +
>>>  gnulib/import/m4/gnulib-comp.m4  |   5 ++
>>>  gnulib/import/m4/sys_wait_h.m4   |  36 +++++++++
>>>  gnulib/import/sys_wait.in.h      | 131 +++++++++++++++++++++++++++++++
>>>  gnulib/update-gnulib.sh          |   1 +
>>>  11 files changed, 340 insertions(+), 6 deletions(-)
>>>  create mode 100644 gnulib/import/m4/sys_wait_h.m4
>>>  create mode 100644 gnulib/import/sys_wait.in.h
>>
>> I don't really know how to assess the risks of merging this, how things
>> could go wrong.  But intuitively I think it should be relatively safe.
>> I'd say go ahead and merge it.
> 
> i feel like this could be a review for every patch ;)

Haha, indeed, that would make life easier.

I meant that maybe somebody knows that we don't want to import a
particular module for some particular reason, a bit like what Eli said.
There might be some instances of this, but if so they should be
documented in gnulib/README, because there's no way to guess otherwise.

> 
> we just branched gdb, so should be a good amount of time to let it bake

Agreed.

Simon