From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MseFD5N8N2E2NwAAWB0awg (envelope-from ) for ; Tue, 07 Sep 2021 10:52:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 34DF91EE22; Tue, 7 Sep 2021 10:52:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0BAA31EDF0 for ; Tue, 7 Sep 2021 10:52:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69F0A385743B for ; Tue, 7 Sep 2021 14:52:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69F0A385743B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631026320; bh=25DFSF0QeQlwoDDmnQYjGMpI3+lK9NverZ5+wXSYgY0=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=MFaUQmJCFUVBKr4+A2x4oCjKoW2H4gtE0UiSoY91bMiYS7TzWcxSIp4h9wlLoe8Zj OjECbAd2WXTf007aldH58VYBMLi3WKVBUzCoLhnMKXrMZ1NVquwOjGNo7ph9z7rIzO 3Il73x1FhphK4f0MAoRbqfupIHg2KvzXIai8rpjA= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 36FD53858D34 for ; Tue, 7 Sep 2021 14:51:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 36FD53858D34 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 187EpaXS011364 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 7 Sep 2021 10:51:41 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 187EpaXS011364 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CD2C81EDF0 for ; Tue, 7 Sep 2021 10:51:36 -0400 (EDT) Subject: Re: [PATCH] gnulib: import sys_wait To: gdb-patches@sourceware.org References: <20210613052519.19005-1-vapier@gentoo.org> Message-ID: <8b41bdc4-69ce-a54a-289d-f69c4d1c5daa@polymtl.ca> Date: Tue, 7 Sep 2021 10:51:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 7 Sep 2021 14:51:36 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-09-04 3:41 a.m., Mike Frysinger wrote: > On 03 Sep 2021 16:54, Simon Marchi wrote: >> On 2021-06-13 1:25 a.m., Mike Frysinger via Gdb-patches wrote: >>> A few sims use this to emulate process syscalls. >>> gnulib/Makefile.in | 4 + >>> gnulib/aclocal.m4 | 1 + >>> gnulib/config.in | 3 + >>> gnulib/configure | 99 +++++++++++++++++++++++ >>> gnulib/import/Makefile.am | 29 +++++++ >>> gnulib/import/Makefile.in | 35 +++++++-- >>> gnulib/import/m4/gnulib-cache.m4 | 2 + >>> gnulib/import/m4/gnulib-comp.m4 | 5 ++ >>> gnulib/import/m4/sys_wait_h.m4 | 36 +++++++++ >>> gnulib/import/sys_wait.in.h | 131 +++++++++++++++++++++++++++++++ >>> gnulib/update-gnulib.sh | 1 + >>> 11 files changed, 340 insertions(+), 6 deletions(-) >>> create mode 100644 gnulib/import/m4/sys_wait_h.m4 >>> create mode 100644 gnulib/import/sys_wait.in.h >> >> I don't really know how to assess the risks of merging this, how things >> could go wrong. But intuitively I think it should be relatively safe. >> I'd say go ahead and merge it. > > i feel like this could be a review for every patch ;) Haha, indeed, that would make life easier. I meant that maybe somebody knows that we don't want to import a particular module for some particular reason, a bit like what Eli said. There might be some instances of this, but if so they should be documented in gnulib/README, because there's no way to guess otherwise. > > we just branched gdb, so should be a good amount of time to let it bake Agreed. Simon