From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PP?] [PATCH v2 04/16] Remove commented-out code from gcore.c
Date: Tue, 20 Oct 2020 10:01:40 -0400 [thread overview]
Message-ID: <8a26934f-d928-9ac5-0229-b1efb588bc04@simark.ca> (raw)
In-Reply-To: <20201019214429.13815-5-tom@tromey.com>
On 2020-10-19 5:44 p.m., Tom Tromey wrote:
> I found some code in gcore.c that has been commented out since
>
> d3420b2fce5e (Mark Kettenis 2003-09-04 166) #if 1 /* See if this even matters... */
>
> This patch deletes this code.
>
> gdb/ChangeLog
> 2020-10-19 Tom Tromey <tom@tromey.com>
>
> * gcore.c (default_gcore_mach): Remove commented-out code.
> ---
> gdb/ChangeLog | 4 ++++
> gdb/gcore.c | 12 ------------
> 2 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/gdb/gcore.c b/gdb/gcore.c
> index db82eaac3dd..c1ea7a6c481 100644
> --- a/gdb/gcore.c
> +++ b/gdb/gcore.c
> @@ -168,19 +168,7 @@ gcore_command (const char *args, int from_tty)
> static unsigned long
> default_gcore_mach (void)
> {
> -#if 1 /* See if this even matters... */
> return 0;
> -#else
> -
> - const struct bfd_arch_info *bfdarch = gdbarch_bfd_arch_info (target_gdbarch ());
> -
> - if (bfdarch != NULL)
> - return bfdarch->mach;
> - if (exec_bfd == NULL)
> - error (_("Can't find default bfd machine type (need execfile)."));
> -
> - return bfd_get_mach (exec_bfd);
> -#endif /* 1 */
> }
The default_gcore_mach function is not needed then, you can remove it
too (replace where it is called with just "0").
Simon
next prev parent reply other threads:[~2020-10-20 14:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 21:44 [PATCH v2 00/16] Remove some macros from exec.h and progspace.h Tom Tromey
2020-10-19 21:44 ` [PATCH v2 01/16] Add target_section constructor Tom Tromey
2020-10-19 21:44 ` [PATCH v2 02/16] Remove exec_filename macro Tom Tromey
2020-10-19 21:44 ` [PATCH v2 03/16] Change exec_close to be a method on program_space Tom Tromey
2020-10-19 21:44 ` [PATCH v2 04/16] Remove commented-out code from gcore.c Tom Tromey
2020-10-20 14:01 ` Simon Marchi [this message]
2020-10-29 1:19 ` [PP?] " Tom Tromey
2020-10-19 21:44 ` [PATCH v2 05/16] Remove exec_bfd_mtime define Tom Tromey
2020-10-19 21:44 ` [PATCH v2 06/16] Remove current_target_sections macro Tom Tromey
2020-10-19 21:44 ` [PATCH v2 07/16] Remove the exec_bfd macro Tom Tromey
2020-10-20 14:24 ` Simon Marchi
2020-10-20 21:20 ` Tom Tromey
2020-10-20 21:34 ` Simon Marchi
2020-10-19 21:44 ` [PATCH v2 08/16] Change program_space::ebfd to a gdb_bfd_ref_ptr Tom Tromey
2020-10-19 21:44 ` [PATCH v2 09/16] Remove symfile_objfile macro Tom Tromey
2020-10-19 21:44 ` [PATCH v2 10/16] Change clear_program_space_solib_cache to method on program_space Tom Tromey
2020-10-19 21:44 ` [PATCH v2 11/16] Change program_space_empty_p " Tom Tromey
2020-10-19 21:44 ` [PATCH v2 12/16] Change remove_target_sections " Tom Tromey
2020-10-20 14:40 ` [PP?] " Simon Marchi
2020-10-29 1:24 ` Tom Tromey
2020-10-19 21:44 ` [PATCH v2 13/16] Change add_target_sections " Tom Tromey
2020-10-19 21:44 ` [PATCH v2 14/16] Change add_target_sections_of_objfile " Tom Tromey
2020-10-19 21:44 ` [PATCH v2 15/16] Don't change current program space in exec_target::close Tom Tromey
2020-10-19 21:44 ` [PATCH v2 16/16] Remove call to exec_close Tom Tromey
2020-10-20 14:46 ` [PP?] [PATCH v2 00/16] Remove some macros from exec.h and progspace.h Simon Marchi
2020-10-29 21:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a26934f-d928-9ac5-0229-b1efb588bc04@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox