Re: [PATCH][gdb/testsuite] Handle multiple sources in build_executable_from_fission_assembler

[Simon Marchi <simark@simark.ca>]

On 2020-11-05 11:40 a.m., Tom de Vries wrote:
> diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
> index 7bb745c71d..c18130b74d 100644
> --- a/gdb/testsuite/lib/dwarf.exp
> +++ b/gdb/testsuite/lib/dwarf.exp
> @@ -29,27 +29,20 @@ proc dwarf2_support {} {
>      return 0
>  }
>
> -# Build an executable from a fission-based .S file.
> +# Build an object from a fission-based .S file SOURCE.

SOURCE_FILE

> @@ -78,7 +71,35 @@ proc build_executable_from_fission_assembler { testname executable sources optio
>  	return -1
>      }
>
> -    set result [gdb_compile $object_file $executable executable $options]
> +    return $object_file
> +}
> +
> +# Build an executable from fission-based .S files FISSION_SOURCES, and regular
> +# SOURCES.  The arguments and results are the same as for build_executable.
> +
> +# Current restrictions:
> +# - cannot be run on remote hosts
> +
> +proc build_executable_from_fission_assembler { testname executable fission_sources sources options } {
> +    verbose -log "build_executable_from_fission_assembler $testname $executable $fission_sources $sources $options"
> +    if [is_remote host] {
> +	error "Remote hosts are not supported."
> +    }
> +
> +    global srcdir subdir
> +
> +    set l [list]

Naming this variable "objects" would be a bit more expressive.

No other comments, thanks.

Simon