From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EksBJSrmql+tFAAAWB0awg (envelope-from ) for ; Tue, 10 Nov 2020 14:12:42 -0500 Received: by simark.ca (Postfix, from userid 112) id 8E71D1F08B; Tue, 10 Nov 2020 14:12:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0FB1B1E58E for ; Tue, 10 Nov 2020 14:12:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCAF9386F818; Tue, 10 Nov 2020 19:12:41 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DAC42386F818 for ; Tue, 10 Nov 2020 19:12:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DAC42386F818 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 787B61E58E; Tue, 10 Nov 2020 14:12:39 -0500 (EST) Subject: Re: [PATCH][gdb/testsuite] Handle multiple sources in build_executable_from_fission_assembler To: Tom de Vries , gdb-patches@sourceware.org References: <20201105164005.GA26356@delia> From: Simon Marchi Message-ID: <89cb556b-17a8-de3e-8f57-1488099751b9@simark.ca> Date: Tue, 10 Nov 2020 14:12:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201105164005.GA26356@delia> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-05 11:40 a.m., Tom de Vries wrote: > diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp > index 7bb745c71d..c18130b74d 100644 > --- a/gdb/testsuite/lib/dwarf.exp > +++ b/gdb/testsuite/lib/dwarf.exp > @@ -29,27 +29,20 @@ proc dwarf2_support {} { > return 0 > } > > -# Build an executable from a fission-based .S file. > +# Build an object from a fission-based .S file SOURCE. SOURCE_FILE > @@ -78,7 +71,35 @@ proc build_executable_from_fission_assembler { testname executable sources optio > return -1 > } > > - set result [gdb_compile $object_file $executable executable $options] > + return $object_file > +} > + > +# Build an executable from fission-based .S files FISSION_SOURCES, and regular > +# SOURCES. The arguments and results are the same as for build_executable. > + > +# Current restrictions: > +# - cannot be run on remote hosts > + > +proc build_executable_from_fission_assembler { testname executable fission_sources sources options } { > + verbose -log "build_executable_from_fission_assembler $testname $executable $fission_sources $sources $options" > + if [is_remote host] { > + error "Remote hosts are not supported." > + } > + > + global srcdir subdir > + > + set l [list] Naming this variable "objects" would be a bit more expressive. No other comments, thanks. Simon