From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Change enable_thread_stack_temporaries to an RAII class
Date: Fri, 09 Mar 2018 03:57:00 -0000 [thread overview]
Message-ID: <8926b4ac-73f3-a7c8-3e7d-cebe3ec4f311@simark.ca> (raw)
In-Reply-To: <20180308053543.18516-1-tom@tromey.com>
On 2018-03-08 12:35 AM, Tom Tromey wrote:
> diff --git a/gdb/infcall.c b/gdb/infcall.c
> index b7f4a176db..a77749f514 100644
> --- a/gdb/infcall.c
> +++ b/gdb/infcall.c
> @@ -411,7 +411,7 @@ struct call_return_meta_info
> CORE_ADDR struct_addr;
>
> /* Whether stack temporaries are enabled. */
> - int stack_temporaries_enabled;
> + bool stack_temporaries_enabled;
I think we can just removed this field, it seems to be unused.
Otherwise LGTM.
Simon
next prev parent reply other threads:[~2018-03-09 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 5:35 Tom Tromey
2018-03-09 3:57 ` Simon Marchi [this message]
2018-03-09 4:58 ` Tom Tromey
2018-03-09 3:58 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8926b4ac-73f3-a7c8-3e7d-cebe3ec4f311@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox